From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF40E35B156 for ; Thu, 22 Jan 2026 07:48:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769068134; cv=none; b=bSJq9233zWcuXPzaN5fUDJbreLHw1tetsScBOk6/Ok0NVfvfyu7A0n55lZERR82aRVxDYCOB0OR5W9bS+aTWCO0JAQd9Vf/+0Ui5jgBsp0aEqygAruFT9V7hHidQguj9F9VESTL4NX8jz4rxDCRMyKFV85RzHy603Wu6dWUrRhE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769068134; c=relaxed/simple; bh=R2a77mienol5oSjR9Ey7rqCNJgsbwPxCgca0RoU3etw=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=sSWp/Y51mGM6XRz4F3cLCwITak66mLEOfLuS2e1Ib+6HQS+WF9CRIlGDnJqzt+VYg0DRp86cUASen43VR3tT3nneIKRLz8xEO9WX4BxDK0cq6hsAjQpESzHtsGmD+LgRpazf7U/drTsk+3J2O6y+9Zm/ZY77iG1ioA9zfkKwrAk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=oRGTDTZ+; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="oRGTDTZ+" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-b8712507269so68844766b.3 for ; Wed, 21 Jan 2026 23:48:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1769068121; x=1769672921; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=R2a77mienol5oSjR9Ey7rqCNJgsbwPxCgca0RoU3etw=; b=oRGTDTZ+hh7Jcn1+DIlE2CmZaNnFboHA7rHNJCxgwAJhPkE3dnoXze/dfdkcLQ3hg1 gSeiDElTzqsJCu8HNfIg2Wqc9t1o/T0OgdAIQhYfS5IKBjkzeYvuUsPsmX0UosKQp12q jG+SgTrlvb3YbPnDwwjTCbX7vKWsm2oko7ldGkrEEJYBUQfWME9vKXQqc34YGaceTjj8 pxS0bLHYvyKCvBxcsTGj83GyYDu3IG7Usb08/VWYd6zP5PHQ8eKd1PT9t+RIKkWGcAaf TFiGMP13bZpfAb8Y10hGPkdVTHT46KdLxKVqwbXMLHQL+kmQ/jUYq3fkak2cXfU79hiz ZuIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769068121; x=1769672921; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=R2a77mienol5oSjR9Ey7rqCNJgsbwPxCgca0RoU3etw=; b=bYcsn0LaeoOR2Xc7awyDk9h/nMhjz1S+s7Tujf/Q5sL4SdZU3Kq5AoK5rK5yRBcvAR 9tfl2+46z7txNVyOIWbbS/7i3GpoC2L7gW9kjpvx4IR8+Uyp2elVFjSZt9lBWl1KjSkG O8AGefQrGcuzlHu1t5LXlNpjescKeqhgbQer9uPlbmwWnqNNsf0j1q7HuERdFGoabb0J 6nsbC4egu/p7UDLkzgwdPwB6W+PUdVPveVTDWrgBVD8SaHEabTJdkfml8g3dIaFRlA3k NLKHpl5TMjAggj3UKV9Kkf44R3ZJnILlPaQ46bDjm7IkkE3pSLPQ2zykuKJYkofzzXbF h14A== X-Forwarded-Encrypted: i=1; AJvYcCUDL7Vbw6lg/xcSmv/ab4SYKhuWencw+cCrwVoZ7zzOFtTa6rxxL1k45AjwTZp1AiFatRpNaht10fAc8hcl@vger.kernel.org X-Gm-Message-State: AOJu0Ywdo/Rab0b4yRFEhmx1/v4423fYQkXlzDHnWfzwtIhRSGn3hWMB eaCvad51dTaRL7Dzx/XLIIoG7VMBdUVpfaFHPGC3HknBS1JHxt5Fe+4P7tjqN5DPhgA= X-Gm-Gg: AZuq6aIk0CFN4ZEAJhs7sgSkENlM3oOUqcKFr6XqVlGJghxMCThNeEnnzqJvAY1//+V vXiPR6KvMhsI6jjZZOWFuNrYJVXYAdZRoP7FsuUI1RMygD8Agv9kNiIaVh1KkceU+PBgb6U8uWW 2pkinBRXMJfCnfLfm1/gFKL9/rZHGq2/3NFC2RbUOYa5mBvdukD5VfISUa22F7izevsgpT0QRdY 0Bo9VhUy3vqAKO5mvwmt5KNb9D2yU93cv5rsgsT8HnrQx09YZPmlfmT9siHQ1PU5fWQ8X9w5vmW x2TruQ/zCygX926rNfAoTuUe3FUuO5KSrvc1bkL6a0Is4C+aXKzdEDua4eMevOqYMfD6YHdr3Fg 5EoktnnZEaXnpkIhwZpwz/Q8dSO5HT1lT+3Fi7CIyaiNSV0aa17juuhB+pIvJMBFhiVnSFaatTO +4NHT25Rr+5MfOdUl/2mbEnyg8GOulSZbsH+LVPd6EZIpwJgN9UPm+srvURWpv1JstwYI= X-Received: by 2002:a17:906:c14c:b0:b87:6:371d with SMTP id a640c23a62f3a-b8800364d31mr589925666b.49.1769068121412; Wed, 21 Jan 2026 23:48:41 -0800 (PST) Received: from localhost (144-178-202-139.static.ef-service.nl. [144.178.202.139]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-654535c49f4sm15830469a12.31.2026.01.21.23.48.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Jan 2026 23:48:41 -0800 (PST) Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 22 Jan 2026 08:48:40 +0100 Message-Id: Cc: "Dmitry Baryshkov" , "Konrad Dybcio" , "Bjorn Andersson" , "Konrad Dybcio" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , <~postmarketos/upstreaming@lists.sr.ht>, , , , , Subject: Re: [PATCH] arm64: dts: qcom: milos-fairphone-fp6: Add Hall Effect sensor From: "Luca Weiss" To: "Dmitry Torokhov" , "Luca Weiss" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260116-fp6-hall-sensor-v1-1-69275c6bd809@fairphone.com> <3a17f2e5-0724-4d70-bd22-1e612142b3e8@oss.qualcomm.com> In-Reply-To: On Wed Jan 21, 2026 at 9:06 PM CET, Dmitry Torokhov wrote: > On Wed, Jan 21, 2026 at 09:07:44AM +0100, Luca Weiss wrote: >> On Wed Jan 21, 2026 at 12:05 AM CET, Dmitry Baryshkov wrote: >> > On Mon, Jan 19, 2026 at 04:52:23PM +0100, Luca Weiss wrote: >> >> On Mon Jan 19, 2026 at 3:41 PM CET, Konrad Dybcio wrote: >> >> > On 1/16/26 3:22 PM, Luca Weiss wrote: >> >> >> Add a node for the Hall Effect sensor, used to detect whether the = Flip >> >> >> Cover is closed or not. >> >> >>=20 >> >> >> The sensor is powered through vreg_l10b, so let's put a >> >> >> regulator-always-on on that to make sure the sensor gets power. >> >> > >> >> > Is there anything else on L10B? Can we turn it off if the hall sens= or >> >> > is e.g. user-disabled? >> >>=20 >> >> It's the voltage source for pull-up of sensor I2C bus (so >> >> ADSP-managed?), DVDD for amplifiers and VDD for a most sensors like >> >> the gyro. >> >>=20 >> >> So realistically, it'll probably be (nearly) always on anyways. And I >> >> don't want to shave another yak by adding vdd support to gpio-keys... >> > >> > Why? If it is exactly what happens on the board: the device producing >> > GPIO events _is_ powered via a vdd. Added Input maintainer / list to c= c. >>=20 >> Yes, the hall sensor which is connected to the GPIO on the SoC, has an >> extra VDD input which needs to be on in order for the Hall-effect sensor >> to be on. >>=20 >> See page 133 "HALL" in the center of the page >> https://www.fairphone.com/wp-content/uploads/2025/08/Fairphone-Gen.-6_-I= nformation-on-how-to-repair-dispose-of-and-recycle-EN-NL-FR-DE.pdf >>=20 >> The IC is OCH166AEV4AD where VDD is (as expected) "Power Supply Input": >> https://www.orient-chip.com/Public/Uploads/uploadfile/files/20231014/1OC= H166Adatasheet202203221.pdf > > If we add regulator support to gpio-keys do we expect it to be > per-gpio/per-key? Or we'd recommend splitting into several instances of > gpio-keys so that there is on set of supplies per gpio-keys device? In my opinion it would fit in this case in the event-hall-sensor node, that next to gpios =3D <&tlmm 70 GPIO_ACTIVE_LOW> we get a vdd-supply =3D <&vreg_l10b>. Regards Luca > > Thanks.