Re: [PATCH net-next 3/3] net: stmmac: "speed" passed to fix_mac_speed is an int

Chen-Yu Tsai
2025-02-18T12:29:18Z

On Tue, Feb 18, 2025 at 6:25 PM Russell King (Oracle)
<rmk+kernel@armlinux.org.uk> wrote:
>
> priv->plat->fix_mac_speed() is called from stmmac_mac_link_up(), which
> is passed the speed as an "int". However, fix_mac_speed() implicitly
> casts this to an unsigned int. Some platform glue code print this value
> using %u, others with %d. Some implicitly cast it back to an int, and
> others to u32.
>
> Good practice is to use one type and only one type to represent a value
> being passed around a driver.
>
> Switch all of these over to consistently use "int" when dealing with a
> speed passed from stmmac_mac_link_up(), even though the speed will
> always be positive.
>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> ---

> drivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c | 2 +-

Acked-by: Chen-Yu Tsai <wens@csie.org>