From: "Eric Gonçalves" <ghatto404@gmail.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] arm64: dts: qcom: r0q: add touchscreen support
Date: Thu, 25 Sep 2025 18:37:23 -0300 [thread overview]
Message-ID: <FFAB92D3-5808-4683-A095-00D1EEFEE962@gmail.com> (raw)
In-Reply-To: <b3151086-206e-4520-9a52-04591478de0a@oss.qualcomm.com>
On September 25, 2025 10:08:37 AM GMT-03:00, Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> wrote:
>On 9/20/25 3:46 AM, Eric Gonçalves wrote:
>> Enable the ST-Microelectronics FTS2BA61Y touchscreen. This patch
>> depends on "Input: add support for the STM FTS2BA61Y touchscreen".
>>
>> The device has an issue where SPI 8 (the bus which the touchscreen is
>> connected to) is not working properly right now, so
>> spi-gpio is used instead.
>>
>> Signed-off-by: Eric Gonçalves <ghatto404@gmail.com>
>> ---
>
>[...]
>
>> &tlmm {
>> gpio-reserved-ranges = <36 4>; /* SPI (Unused) */
>> +
>> + spi_clk_tsp_active: spi_clk_tsp_active {
>> + mux {
>> + pins = "gpio30";
>> + function = "gpio";
>> + };
>> + config {
>> + pins = "gpio30";
>> + drive-strength = <6>;
>> + bias-disable;
>> + };
>> + };
>
>Drop mux/config, put all the properties right under the pin definition
>
>> +
>> + spi_clk_tsp_sleep: spi_clk_tsp_sleep {
>
>Underscores are forbidden in node names, use dashes instead
>
>Konrad
Will do, thanks
next prev parent reply other threads:[~2025-09-25 21:37 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-20 1:46 [PATCH 0/5] arm64: dts: qcom: r0q: enable more peripherals Eric Gonçalves
2025-09-20 1:46 ` [PATCH 1/5] arm64: dts: qcom: r0q: add gpio keys Eric Gonçalves
2025-09-20 15:45 ` Dmitry Baryshkov
2025-09-20 18:02 ` Eric Gonçalves
2025-09-20 20:15 ` Dmitry Baryshkov
2025-09-20 20:22 ` Eric Gonçalves
2025-09-20 23:21 ` Dmitry Baryshkov
2025-09-20 1:46 ` [PATCH 2/5] arm64: dts: qcom: r0q: add touchscreen support Eric Gonçalves
2025-09-20 15:46 ` Dmitry Baryshkov
2025-09-25 13:08 ` Konrad Dybcio
2025-09-25 21:37 ` Eric Gonçalves [this message]
2025-09-20 1:46 ` [PATCH 3/5] arm64: dts: qcom: r0q: enable max77705 PMIC Eric Gonçalves
2025-09-20 15:48 ` Dmitry Baryshkov
2025-09-20 18:04 ` Eric Gonçalves
2025-09-25 13:06 ` Konrad Dybcio
2025-09-26 2:19 ` Eric Gonçalves
2025-10-08 8:34 ` Konrad Dybcio
2025-10-09 20:31 ` Eric Gonçalves
2025-10-20 12:06 ` Konrad Dybcio
2025-09-20 1:46 ` [PATCH 4/5] arm64: dts: qcom: r0q: enable hardware clocks Eric Gonçalves
2025-09-25 13:09 ` Konrad Dybcio
2025-10-05 3:50 ` Eric Gonçalves
2025-10-06 12:31 ` Konrad Dybcio
2025-10-06 15:49 ` Eric Gonçalves
2025-10-08 8:48 ` Konrad Dybcio
2025-10-09 19:20 ` Eric Gonçalves
2025-09-20 1:46 ` [PATCH 5/5] arm64: dts: qcom: r0q: enable ufs storage Eric Gonçalves
2025-09-20 20:16 ` Dmitry Baryshkov
2025-09-25 13:07 ` Konrad Dybcio
2025-09-25 21:37 ` Eric Gonçalves
2025-10-06 12:08 ` Konrad Dybcio
2025-10-06 15:49 ` Eric Gonçalves
2025-09-22 17:27 ` [PATCH 0/5] arm64: dts: qcom: r0q: enable more peripherals Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FFAB92D3-5808-4683-A095-00D1EEFEE962@gmail.com \
--to=ghatto404@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox