From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8EF6C4167B for ; Sun, 18 Dec 2022 11:10:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230078AbiLRLKv (ORCPT ); Sun, 18 Dec 2022 06:10:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230157AbiLRLKt (ORCPT ); Sun, 18 Dec 2022 06:10:49 -0500 X-Greylist: delayed 97 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Sun, 18 Dec 2022 03:10:48 PST Received: from relay07.th.seeweb.it (relay07.th.seeweb.it [IPv6:2001:4b7a:2000:18::168]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E4E31BE; Sun, 18 Dec 2022 03:10:47 -0800 (PST) Received: from [192.168.2.144] (adsl-d248.84-47-10.t-com.sk [84.47.10.248]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id D707D3EF28; Sun, 18 Dec 2022 12:10:43 +0100 (CET) Date: Sun, 18 Dec 2022 12:10:37 +0100 From: Martin Botka Subject: Re: [PATCH v4 3/4] arm64: dts: qcom: sm6125: Add apps_smmu with streamID to SDHCI 1/2 nodes To: Marijn Suijten Cc: phone-devel@vger.kernel.org, Will Deacon , Joerg Roedel , Bjorn Andersson , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Jami Kettunen , Lux Aliaga , Robin Murphy , Rob Herring , Krzysztof Kozlowski , Andy Gross , Konrad Dybcio , Dmitry Baryshkov , Thierry Reding , Melody Olvera , Greg Kroah-Hartman , Bhupesh Sharma , Douglas Anderson , linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Message-Id: In-Reply-To: <20221216215819.1164973-4-marijn.suijten@somainline.org> References: <20221216215819.1164973-1-marijn.suijten@somainline.org> <20221216215819.1164973-4-marijn.suijten@somainline.org> X-Mailer: geary/40.0 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, Dec 16 2022 at 10:58:18 PM +01:00:00, Marijn Suijten wrote: > When enabling the APPS SMMU the mainline driver reconfigures the SMMU > from its bootloader configuration, loosing the stream mapping for > (among > which) the SDHCI hardware and breaking its ADMA feature. This feature > can be disabled with: > > sdhci.debug_quirks=0x40 > > But it is of course desired to have this feature enabled and working > through the SMMU. > > Signed-off-by: Marijn Suijten > --- > arch/arm64/boot/dts/qcom/sm6125.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm6125.dtsi > b/arch/arm64/boot/dts/qcom/sm6125.dtsi > index 347665c2067c..f560499cc0ca 100644 > --- a/arch/arm64/boot/dts/qcom/sm6125.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm6125.dtsi > @@ -468,6 +468,7 @@ sdhc_1: mmc@4744000 { > <&gcc GCC_SDCC1_APPS_CLK>, > <&xo_board>; > clock-names = "iface", "core", "xo"; > + iommus = <&apps_smmu 0x160 0>; > > power-domains = <&rpmpd SM6125_VDDCX>; > > @@ -494,6 +495,7 @@ sdhc_2: mmc@4784000 { > <&gcc GCC_SDCC2_APPS_CLK>, > <&xo_board>; > clock-names = "iface", "core", "xo"; > + iommus = <&apps_smmu 0x180 0>; > > pinctrl-0 = <&sdc2_on_state>; > pinctrl-1 = <&sdc2_off_state>; > -- > 2.39.0 > With 0x0 as mask Reviewed-by: Martin Botka -Martin