From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7B82C4361B for ; Sat, 5 Dec 2020 05:00:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9F1CC23101 for ; Sat, 5 Dec 2020 05:00:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726016AbgLEFAn (ORCPT ); Sat, 5 Dec 2020 00:00:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725730AbgLEFAm (ORCPT ); Sat, 5 Dec 2020 00:00:42 -0500 Received: from mail-ot1-x343.google.com (mail-ot1-x343.google.com [IPv6:2607:f8b0:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41E39C061A51 for ; Fri, 4 Dec 2020 20:59:56 -0800 (PST) Received: by mail-ot1-x343.google.com with SMTP id j21so7389234otp.8 for ; Fri, 04 Dec 2020 20:59:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=wSgUGUXnFDKhHhb8WtgZMF/PzYufjbjvE9QiZ+cHEwU=; b=wNe+86mm6puGFc4cLUdEco/Xg9dylu4KR3rHFgk/5vH/fN/B2WDFuN1yI8Q0gzhA+m EXDCccbDopJF8zmUciXtRO9A97qjI2q+D/TpwlGtQAfR1tAOvT62SkT+q9GbPT7FmOIt BUjHulnXCu6Hsia4155jBq8j9VeaNDQzjNGyb4tlrBUEZtW6fNoY2H8A+tJ+XrY/lrBz rkyfEi4ZG+1s2GDI1k2UvvS9mKJAPBB8O9EcQX0etgEGCvVPlFkHKqhGlOlMo+72TZAI 4HTkHETvC7CZowht4H9tcc5fgWajbcU8VuvDT84H1L9choH2nqZfT7WXGmsuvj0O6Phx kYPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wSgUGUXnFDKhHhb8WtgZMF/PzYufjbjvE9QiZ+cHEwU=; b=qQEpqHvIv1PzzBPjcmtzNzgrOp8QA2VyJa678rObMZfUNE8lYeEIjONsXWHGDfHwh2 0obNy1d7q+K577P/+U1qd65eEfH5VsoJH/9gNnb/TkZSHh18NzmNJ+PMlTKNdjIvt+8O zBLGaubIweZUHgpohg4/qoR4uhwNAOBe/4ntWLOSoY6svpbR/Dni+yN/qMvjEG+9QFra BuOveIgQMAi8UCIzig9q/s5Gh+2oyh7FGmAXj7USq+2BOa2P1j+kIerSR0Eq0Asl9Uw4 Q1DqG/P5ESMaD6EDV3KmxRud2JrF4/qrsIIh37l0dXVgSbSf6ZBvmfjbNN0npPvW5rwy 4Wow== X-Gm-Message-State: AOAM532Dr4Efl2+ns85lHrh5LEbCSdWSvJm9u9Ls5tmVYege07/nBnAy WXNBfEzk+W/XYK62gKZlE93SCQ== X-Google-Smtp-Source: ABdhPJwstogV1jeXnSfg4AfmH0pdZThD9cHD4d9HCGJkiYftNyN/ePerd0utakaOsDm0rmg+t10Ymw== X-Received: by 2002:a9d:3435:: with SMTP id v50mr6044996otb.292.1607144395452; Fri, 04 Dec 2020 20:59:55 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id h17sm1136458oor.1.2020.12.04.20.59.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Dec 2020 20:59:54 -0800 (PST) Date: Fri, 4 Dec 2020 22:59:52 -0600 From: Bjorn Andersson To: kholk11@gmail.com Cc: agross@kernel.org, sboyd@kernel.org, marijns95@gmail.com, konradybcio@gmail.com, martin.botka1@gmail.com, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] clk: qcom: Add SDM660 Multimedia Clock Controller (MMCC) driver Message-ID: References: <20200926130306.13843-1-kholk11@gmail.com> <20200926130306.13843-2-kholk11@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200926130306.13843-2-kholk11@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Sat 26 Sep 08:03 CDT 2020, kholk11@gmail.com wrote: > diff --git a/drivers/clk/qcom/mmcc-sdm660.c b/drivers/clk/qcom/mmcc-sdm660.c [..] > +static int mmcc_660_probe(struct platform_device *pdev) > +{ > + struct regmap *regmap; > + bool is_sdm630 = 0; This shouldn't be 0, but there's no need for initializing it either, as the first reference is an assignment. On the other hand, you could without loss of clarity just move the of_device_is_compatible() into the if statement directly. > + > + regmap = qcom_cc_map(pdev, &mmcc_660_desc); > + if (IS_ERR(regmap)) > + return PTR_ERR(regmap); > + > + is_sdm630 = of_device_is_compatible(pdev->dev.of_node, > + "qcom,mmcc-sdm630"); > + > + clk_alpha_pll_configure(&mmpll3, regmap, &mmpll3_config); > + clk_alpha_pll_configure(&mmpll4, regmap, &mmpll4_config); > + clk_alpha_pll_configure(&mmpll5, regmap, &mmpll5_config); > + clk_alpha_pll_configure(&mmpll7, regmap, &mmpll7_config); > + clk_alpha_pll_configure(&mmpll8, regmap, &mmpll8_config); > + clk_alpha_pll_configure(&mmpll10, regmap, &mmpll10_config); > + > + if (is_sdm630) { > + mmcc_660_desc.clks[BYTE1_CLK_SRC] = 0; > + mmcc_660_desc.clks[MDSS_BYTE1_CLK] = 0; > + mmcc_660_desc.clks[MDSS_BYTE1_INTF_DIV_CLK] = 0; > + mmcc_660_desc.clks[MDSS_BYTE1_INTF_CLK] = 0; > + mmcc_660_desc.clks[ESC1_CLK_SRC] = 0; > + mmcc_660_desc.clks[MDSS_ESC1_CLK] = 0; > + mmcc_660_desc.clks[PCLK1_CLK_SRC] = 0; > + mmcc_660_desc.clks[MDSS_PCLK1_CLK] = 0; > + } > + > + return qcom_cc_really_probe(pdev, &mmcc_660_desc, regmap); > +} > + > +static struct platform_driver mmcc_660_driver = { > + .probe = mmcc_660_probe, > + .driver = { > + .name = "mmcc-sdm660", > + .of_match_table = mmcc_660_match_table, > + }, > +}; > + > +static int __init mmcc_660_init(void) > +{ > + return platform_driver_register(&mmcc_660_driver); > +} > +core_initcall_sync(mmcc_660_init); > + > +static void __exit mmcc_660_exit(void) > +{ > + platform_driver_unregister(&mmcc_660_driver); > +} > +module_exit(mmcc_660_exit); > + The driver is tristate (which is correct), but for that you need a MODULE_LICENSE at least. > diff --git a/include/dt-bindings/clock/qcom,mmcc-sdm660.h b/include/dt-bindings/clock/qcom,mmcc-sdm660.h Please move this to the dt-binding patch, and reorder the two. > new file mode 100644 > index 000000000000..f9dbc21cb5c7 > --- /dev/null > +++ b/include/dt-bindings/clock/qcom,mmcc-sdm660.h > @@ -0,0 +1,162 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ And please make this "GPL-2.0-only OR BSD-2-Clause". Regards, Bjorn