From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBF23C4361B for ; Thu, 10 Dec 2020 19:40:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9F05D23DC4 for ; Thu, 10 Dec 2020 19:40:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390239AbgLJTkS (ORCPT ); Thu, 10 Dec 2020 14:40:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390207AbgLJTkK (ORCPT ); Thu, 10 Dec 2020 14:40:10 -0500 Received: from mail-ot1-x341.google.com (mail-ot1-x341.google.com [IPv6:2607:f8b0:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C1E7C0613CF for ; Thu, 10 Dec 2020 11:39:30 -0800 (PST) Received: by mail-ot1-x341.google.com with SMTP id 11so6020777oty.9 for ; Thu, 10 Dec 2020 11:39:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yHzvb2sgyrs64+/rhHq/tafMxJLiYEjE09CUgIMJcQ0=; b=wxgHsjQy52z3s3rniJvqnVXsR8jFNDXeviwLD2pFPDVmPRCOEtnESHY46RNyvHS1LA FFADQOD0OQKz6PWR6lqnZwssfNwrcFER3DH2qmyE5I9J7Nc+ysXNo4qhPxjTjX8h3Q5l wKzY9q2vMQMoiGkR0iSshcsWBxJHlrCG3guICfuQaeCa4L+gGbuaGRdv8/dBWK6nXT0v xR3B+K4ti4crdQfjU0C2KjC4AHK0upAUrGpvUHVtiV9IfJgo5A3PhX3c0+EFwCBxiJwH I/NmGenXqRbLlaqJbfNij2iZd+2ckuvtHrDjIN2bgGfUEa8PAnPvP79SMiv2IUFmiuDI sA4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yHzvb2sgyrs64+/rhHq/tafMxJLiYEjE09CUgIMJcQ0=; b=JPBxBeO/AahYB/E4XYhp836YvsAumkKK3XGwObWvz4S5JREVQ4whDuLzmnn9e6E6p4 xpSHYgLwIQEtJKbl5osvZzMJXbOv1CX0AIsAQf32h1y0pqOEIwKhRgcmAOFTX64S4eAN XP6q0dhYEebcS3z6fvP1jtLvMFNbcqZcxL6JVMfOu/4kITLX53M/BQ8445vu9Lc2HfYo AF+ClaphuH2KokZSyRWfFmcH+4Wf01a5KjhmRkrKcfDISJjSoMIT07bF6a+hnPPMsO61 DqQCCP6aQpjHNswBOLKU8QdqpeHWEWr6pvv+SyOeDim9ubziIl/nh6M2UiUG3TxotmY4 4XFQ== X-Gm-Message-State: AOAM531wFejdQWdCr97hICS7x+h6EMyF3OUSmcY8ZgJ/62rEbrSgn7L2 ctrEENLksCabibip5owQzw868A== X-Google-Smtp-Source: ABdhPJyARyz6Uv2FqxNvjikZOjkC6dD1pbICaNS8YPWWFBTuVD1T357vgbLbnn8hMA3bgW9BT+gDVg== X-Received: by 2002:a9d:27ea:: with SMTP id c97mr6862385otb.173.1607629169438; Thu, 10 Dec 2020 11:39:29 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id h2sm1290612otn.15.2020.12.10.11.39.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Dec 2020 11:39:28 -0800 (PST) Date: Thu, 10 Dec 2020 13:39:27 -0600 From: Bjorn Andersson To: Douglas Anderson Cc: Stephen Boyd , Taniya Das , vbadigan@codeaurora.org, Andy Gross , Michael Turquette , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] clk: qcom: gcc-sc7180: Use floor ops for sdcc clks Message-ID: References: <20201210102234.1.I096779f219625148900fc984dd0084ed1ba87c7f@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201210102234.1.I096779f219625148900fc984dd0084ed1ba87c7f@changeid> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu 10 Dec 12:22 CST 2020, Douglas Anderson wrote: > I would repeat the same commit message that was in commit 5e4b7e82d497 > ("clk: qcom: gcc-sdm845: Use floor ops for sdcc clks") but it seems > silly to do so when you could just go read that commit. > > NOTE: this is actually extra terrible because we're missing the 50 MHz > rate in the table (see the next patch AKA ("clk: qcom: gcc-sc7180: Add > 50 MHz clock rate for SDC2")). That means then when you run an older > SD card it'll try to clock it at 100 MHz when it's only specced to run > at 50 MHz max. As you can probably guess that doesn't work super > well. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Douglas Anderson > Fixes: 17269568f726 ("clk: qcom: Add Global Clock controller (GCC) driver for SC7180") > --- > Taniya: can you please update whatever process is used to generate > these clock files to use floor for SD card clocks. I hope you can > also scour through these files looking for similar problems on other > SoCs and submit patches for them. > > drivers/clk/qcom/gcc-sc7180.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/qcom/gcc-sc7180.c b/drivers/clk/qcom/gcc-sc7180.c > index 68d8f7aaf64e..b080739ab0c3 100644 > --- a/drivers/clk/qcom/gcc-sc7180.c > +++ b/drivers/clk/qcom/gcc-sc7180.c > @@ -642,7 +642,7 @@ static struct clk_rcg2 gcc_sdcc1_ice_core_clk_src = { > .name = "gcc_sdcc1_ice_core_clk_src", > .parent_data = gcc_parent_data_0, > .num_parents = 4, > - .ops = &clk_rcg2_ops, > + .ops = &clk_rcg2_floor_ops, > }, > }; > > @@ -666,7 +666,7 @@ static struct clk_rcg2 gcc_sdcc2_apps_clk_src = { > .name = "gcc_sdcc2_apps_clk_src", > .parent_data = gcc_parent_data_5, > .num_parents = 5, > - .ops = &clk_rcg2_ops, > + .ops = &clk_rcg2_floor_ops, > }, > }; > > -- > 2.29.2.576.ga3fc446d84-goog >