From: Pavel Machek <pavel@ucw.cz>
To: Gergo Koteles <soyer@irl.hu>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
Caleb Connolly <caleb@connolly.tech>
Subject: Re: [PATCH v2 3/3] arm64: dts: qcom: sdm845-oneplus: add tri-state-key
Date: Sat, 11 Feb 2023 17:40:14 +0100 [thread overview]
Message-ID: <Y+fE7gIMD4BDCffy@duo.ucw.cz> (raw)
In-Reply-To: <20230209232556.91554-1-soyer@irl.hu>
[-- Attachment #1: Type: text/plain, Size: 549 bytes --]
Hi!
> +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
> @@ -52,6 +52,43 @@ key-vol-up {
> };
> };
>
> + tri-state-key {
> + compatible = "gpio-keys";
> + label = "Tri-state key";
> + pinctrl-names = "default";
> + pinctrl-0 = <&tri_state_key_default>;
> + state-top {
> + label = "Tri-state key top";
"top/middle" is not too useful. Do we need the label at all? If so,
should it say "loud/vibrations only/mute"?
BR,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2023-02-11 16:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 23:25 [PATCH v2 3/3] arm64: dts: qcom: sdm845-oneplus: add tri-state-key Gergo Koteles
2023-02-10 11:33 ` Krzysztof Kozlowski
2023-02-10 13:45 ` Gergo Koteles
2023-02-10 13:53 ` Konrad Dybcio
2023-02-11 16:40 ` Pavel Machek [this message]
2023-02-12 1:58 ` Caleb Connolly
2023-02-16 3:32 ` Gergo Koteles
2023-02-19 15:30 ` Caleb Connolly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+fE7gIMD4BDCffy@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=caleb@connolly.tech \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jikos@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=soyer@irl.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox