From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EACC4C433F5 for ; Sat, 8 Oct 2022 09:51:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229699AbiJHJvW (ORCPT ); Sat, 8 Oct 2022 05:51:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229695AbiJHJvV (ORCPT ); Sat, 8 Oct 2022 05:51:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C53A5FC7; Sat, 8 Oct 2022 02:51:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EBA0D60A5A; Sat, 8 Oct 2022 09:51:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C05B9C433D6; Sat, 8 Oct 2022 09:51:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1665222679; bh=x13HOIyD9suTVaFon3YOufV/ukJs++5vFFe4lyLKq8s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ucw/4c33UnsaixjglaVysYOQszO9SclUkKPpu4TblPcpqpDbAEsifY4ZLQGzhzWNM mIx5OqB5x06BuuN3HL4HxNBXNk7K/N4x2FKfLJiJjqJLYayNOw1uxO5haIhMQx1ekf isFo1ffZtrZZMtAeGHLHPgFrA2T6xgE7iTcFMyQU= Date: Sat, 8 Oct 2022 11:52:01 +0200 From: Greg Kroah-Hartman To: Zhou Furong Cc: Elliot Berman , Bjorn Andersson , Jiri Slaby , Murali Nalajala , Trilok Soni , Srivatsa Vaddagiri , Carl van Schaik , Andy Gross , Dmitry Baryshkov , Jassi Brar , linux-arm-kernel@lists.infradead.org, Mark Rutland , Lorenzo Pieralisi , Sudeep Holla , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet , Will Deacon , Catalin Marinas , Arnd Bergmann , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 14/14] tty: gunyah: Add tty console driver for RM Console Services Message-ID: References: <20220928195633.2348848-1-quic_eberman@quicinc.com> <20220928195633.2348848-15-quic_eberman@quicinc.com> <4cb5e7eb-1571-ed91-e1da-b4223a26f41c@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4cb5e7eb-1571-ed91-e1da-b4223a26f41c@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Sat, Oct 08, 2022 at 03:41:53PM +0800, Zhou Furong wrote: > > > > + > > > +/* > > > + * The Linux TTY code does not support dynamic addition of tty derived devices so we need to know > > > + * how many tty devices we might need when space is allocated for the tty device. Since VMs might be > > > + * added/removed dynamically, we need to make sure we have enough allocated. > > > > Wrap comments at 80 columns please. > > > > checkpatch has extend LINE MAX to 100,do we still suggest wrap to 80? For comment blocks, yes please.