Re: [PATCH v2 1/3] dt-bindings: arm: qcom: Document QDU1000/QRU1000 SoCs and boards

Krzysztof Kozlowski
2022-10-15T13:19:38Z

On 14/10/2022 18:11, Melody Olvera wrote:
> Document the QDU1000 and QRU1000 SoC bindings and the boards that use
> them.
>
> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
> ---
> Documentation/devicetree/bindings/arm/qcom.yaml | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 1b5ac6b02bc5..3370a50644a6 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -40,6 +40,8 @@ description: |
> msm8996
> msm8998
> qcs404
> + qdu1000
> + qru1000
> sa8155p
> sa8540p
> sc7180
> @@ -76,6 +78,7 @@ description: |
> mtp
> qrd
> sbc
> + x100
>
> The 'soc_version' and 'board_version' elements take the form of v<Major>.<Minor>
> where the minor number may be omitted when it's zero, i.e. v1.0 is the same
> @@ -493,6 +496,19 @@ properties:
> - const: google,pompom-sku0
> - const: qcom,sc7180
>
> + - description: Qualcomm Technologies, Inc. Distributed Unit 1000 platform
> + - items:
> + - enum:
> + - qcom,qdu1000-idp
> + - qcom,qdu1000-x100
> + - const: qcom,qdu1000
> +
> + - description: Qualcomm Technologies, Inc. Radio Unit 1000 platform
> + - items:
> + - enum:
> + -qcom,qru1000-idp
> + - const: qcom,qru1000

This is still wrong order. All entries are ordered by SoC compatible. So
this should go before sc7180, not after.

> +
> - description: Google Quackingstick (newest rev)
> items:
> - const: google,quackingstick-sku1537

Best regards,
Krzysztof