From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08314C38A02 for ; Fri, 28 Oct 2022 06:09:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229668AbiJ1GJj (ORCPT ); Fri, 28 Oct 2022 02:09:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229536AbiJ1GJg (ORCPT ); Fri, 28 Oct 2022 02:09:36 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 272C4C7F; Thu, 27 Oct 2022 23:09:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2064F62670; Fri, 28 Oct 2022 06:09:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7AEA9C433C1; Fri, 28 Oct 2022 06:09:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666937367; bh=UuiTRQk+7GReGbCZDOgtZ7lgyZlujMjbgmrzbepu8Xk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eHQUOqee88v8iCfjOZ2CPFb5YlM53mWWj5Ok0KL2pun8rat0+daypr40Y+y5MKpUq ABX+HsUoonKyodFi2MUkpcrCLLL/dxFH3D6H7EyT+6KhjUcfqyEtgqBcLIdmbndQ1i cM1Oy627YyW9jKVgoUgJnk1JjHL6u7s7SwTHOysyHkssa3q8P09+YvDsltQoJirquF v5B3+GwqllIOHkqwl61iCmRb89GHWf8HsFHgOMNbY9bWruROAEFnQ3px2xqmMgvmJV sFWUMQykws5bZADx5WATTucBRRV3uZqkZQKbvnOttf6Ioe8xNeKJf07zAGkdcvkYcA 9sSLVRLC43xtw== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1ooIYJ-0005Km-Uy; Fri, 28 Oct 2022 08:09:12 +0200 Date: Fri, 28 Oct 2022 08:09:11 +0200 From: Johan Hovold To: Krzysztof Kozlowski Cc: Johan Hovold , Vinod Koul , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/13] dt-bindings: phy: qcom,qmp-usb: fix sc8280xp binding Message-ID: References: <20221024100632.20549-1-johan+linaro@kernel.org> <20221024100632.20549-12-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, Oct 27, 2022 at 10:15:45PM -0400, Krzysztof Kozlowski wrote: > On 24/10/2022 06:06, Johan Hovold wrote: > > The current QMP USB PHY bindings are based on the original MSM8996 PCIe > > PHY binding which provided multiple PHYs per IP block and these in turn > > were described by child nodes. > > > > The QMP USB PHY block only provide a single PHY and the remnant child > > node does not really reflect the hardware. > > > > The original MSM8996 binding also ended up describing the individual > > register blocks as belonging to either the wrapper node or the PHY child > > nodes. > > > > (...) > > > then: > > diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb-phy.yaml > > new file mode 100644 > > index 000000000000..95ee81d782f9 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb-phy.yaml > > Filename based on compatible, so in this case > "qcom,sc8280xp-qmp-usb3-uni-phy.yaml", unless it's like the PCI case? Yes, you're right. Thanks for catching that. This should be the only sc8280xp USB PHY compatible so the file name should be updates as you suggested. I'll wait a bit and see if Vinod has any comments before respinning this series. Johan