From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8147C4332F for ; Mon, 21 Nov 2022 07:47:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229653AbiKUHrE (ORCPT ); Mon, 21 Nov 2022 02:47:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229894AbiKUHrC (ORCPT ); Mon, 21 Nov 2022 02:47:02 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FF06EB0; Sun, 20 Nov 2022 23:46:58 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1C0E360DBB; Mon, 21 Nov 2022 07:46:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 664F2C433C1; Mon, 21 Nov 2022 07:46:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669016817; bh=jG4j8KgJyQC/+rnV3jJ8fSMV3b8HphQv1Xahnz08T+M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QnXy1IrVs/9dnbwaydjyZJu/4Wl4uRlCj3qkFUSSqd/0jbvAnxSGNoEUhxYci35Is gGgMwoh+D85PlwyUvQ0PLftBFekdV4dd/ogyxeE5N3Q8JJke9x0FEfaB/gpn7HDW8c Pum4lWeKX9O1az2P1i/K8k6VceaGwkMxgde759z9G6w6oq9ulQOZcV8SfHhwJvRxxu UMIBwyKXfk9em21f/AjJVPWb+sKKtFhKj8W5yzAtUqHtPz0jc5GE+Y3DORtP0UpgQG JiOUnGgy7h9lJIFM/UDMY8zC1QBeI2oeoVWjlUswPJKUxmSuVA76o85ySNDMFmhkW4 /KuPd5xLDqD3A== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1ox1Vb-00069e-Ir; Mon, 21 Nov 2022 08:46:27 +0100 Date: Mon, 21 Nov 2022 08:46:27 +0100 From: Johan Hovold To: Srinivas Kandagatla Cc: agross@kernel.org, andersson@kernel.org, konrad.dybcio@somainline.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] arm64: dts: qcom: sc8280xp/sa8540p: add gpr node Message-ID: References: <20221119164425.86014-1-srinivas.kandagatla@linaro.org> <20221119164425.86014-2-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221119164425.86014-2-srinivas.kandagatla@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Sat, Nov 19, 2022 at 04:44:23PM +0000, Srinivas Kandagatla wrote: > Add GPR node along with APM(Audio Process Manager) and PRM(Proxy > resource Manager) audio services. > > Signed-off-by: Srinivas Kandagatla > --- > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 40 ++++++++++++++++++++++++++ > 1 file changed, 40 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > index c32bcded2aef..a610c12103bf 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include Again, please keep the includes sorted. > / { > interrupt-parent = <&intc>; > @@ -1152,9 +1153,48 @@ IPCC_MPROC_SIGNAL_GLINK_QMP > > label = "lpass"; > qcom,remote-pid = <2>; > + > + gpr { > + compatible = "qcom,gpr"; > + qcom,glink-channels = "adsp_apps"; > + qcom,domain = ; > + qcom,intents = <512 20>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + q6apm: service@1 { > + compatible = "qcom,q6apm"; > + reg = ; > + #sound-dai-cells = <0>; > + qcom,protection-domain = "avs/audio", > + "msm/adsp/audio_pd"; > + q6apmdai: dais { > + compatible = "qcom,q6apm-dais"; > + iommus = <&apps_smmu 0x0c01 0x0>; > + }; > + > + q6apmbedai: bedais { > + compatible = "qcom,q6apm-lpass-dais"; > + #sound-dai-cells = <1>; > + }; > + }; > + > + q6prm: service@2 { > + compatible = "qcom,q6prm"; > + reg = ; > + qcom,protection-domain = "avs/audio", > + "msm/adsp/audio_pd"; > + q6prmcc: clock-controller { > + compatible = "qcom,q6prm-lpass-clocks"; > + clock-controller; > + #clock-cells = <2>; > + }; > + }; > + }; > }; > }; > > + Drop the stray newline. > usb_0_qmpphy: phy-wrapper@88ec000 { > compatible = "qcom,sc8280xp-qmp-usb43dp-phy"; > reg = <0 0x088ec000 0 0x1e4>, Johan