Re: [PATCH v2 1/2] dt-bindings: arm: qcom: Adding DT binding for zombie

Matthias Kaehlcke
2022-11-23T15:07:47Z

On Wed, Nov 23, 2022 at 02:02:38PM +0800, 楊宗翰 wrote:
> HiÂ Matthias ,
>
> When I run "patman" still get warning "<patch>:36: warning: added, moved or
> deleted file(s), does MAINTAINERS need updating?"

The warning is expected because you added new files. In this case you can
ignore it as it isn't expected that you become the maintainer of the new zombie
DT files.

> And I screenshot my "git gui" as below(attachment "git_gui_screenshot.jpg"):
> [image.png]
>
> The latest git log info as below:
> ---
> commit 4d2b529bce125b83c546aebbc36ecedf76dfc55e (linux_qcom/for-next)
> Merge: 9abf2313adc1 c03fa428ac6e afcd946be11c aec5f36cf676 cea42b8d7966
> aa9f474014b1 37b5e8c48b9d cadaa773bcf1
> Author: Bjorn Andersson <andersson@kernel.org>
> Date: Â  Tue Nov 15 11:45:55 2022 -0600
>
> Â  Â  Merge branches 'arm64-defconfig-for-6.2', 'arm64-for-6.2', 'clk-for-6.2',
> 'defconfig-for-6.2', 'drivers-for-6.2', 'dts-for-6.2' and 'arm64-fixes-for-6.1'
> into for-next
> ---
>
> My checkout steps as below:
> $ git remote add linux_qcomÂ git://git.kernel.org/pub/scm/linux/kernel/git/
> qcom/linux.git
> $ git fetch --no-tags linux_qcom
> $ git checkout -b <MyLocalBranchName> linux_qcom/for-next
>
> Is myÂ code base branch still worng?Â  Am IÂ missing something?Â

My understanding is that it is best to base you changes on a branch like
'arm64-for-6.2' as the 'for-next' branch is re-created every time changes
land in one of the '${area}-for-${version}' branches.

No big issue in this case, just use the corresponding '${area}-for-${version}'
branch for future patches/versions :)

> The attachment is "0001-dt-bindings-arm-qcom-Adding-DT-binding-for-
> zombie.patch" patch file,
> Â I have drop "Documentation/devicetree/bindings/arm/qcom.yaml" as your advice.
>
> Matthias Kaehlcke <mka@chromium.org> æ–¼ 2022å¹´11æœˆ22æ—¥ é€±äºŒ æ™šä¸Š10:
> 28å¯«é“ï¼š
> On which tree is this series based? My earlier reply bounced for
> Bjorn's
> old Linaro e-mail address, which suggests that the series might be
> based
> on an older kernel tree (maybe downstream Chrome OS v5.15?). Please
> make
> sure to base patches to upstream lists on the corresponding
> maintainer
> tree/branch or a recent kernel version/rc.
>
> On Tue, Nov 22, 2022 at 08:37:02PM +0800, Owen Yang wrote:
> > Add an entry in the device tree binding for sc7280-zombie.
> >
> > Documentation/devicetree/bindings/arm/qcom.yaml
> >
> > Signed-off-by: Owen Yang <ecs.taipeikernel@gmail.com>
> > ---
> >
> > Changes in v2:
> > - Move binding item to Google series bottom.
> > - Modify DT file for zombie.
> >
> >Â  Documentation/devicetree/bindings/arm/qcom.yaml | 10 ++++++++++
> >Â  1 file changed, 10 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/
> Documentation/devicetree/bindings/arm/qcom.yaml
> > index c15a729a6852..f617923f7485 100644
> > --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> > @@ -538,6 +538,16 @@ properties:
> >Â  Â  Â  Â  Â  Â  - const: google,villager-sku512
> >Â  Â  Â  Â  Â  Â  - const: qcom,sc7280
> >Â
> > +Â  Â  Â  - description: Google Zombie (newest rev)
> > +Â  Â  Â  Â  items:
> > +Â  Â  Â  Â  Â  - const: google,zombie
> > +Â  Â  Â  Â  Â  - const: qcom,sc7280
> > +
> > +Â  Â  Â  - description: Google Zombie with LTE (newest rev)
> > +Â  Â  Â  Â  items:
> > +Â  Â  Â  Â  Â  - const: google,zombie-sku512
> > +Â  Â  Â  Â  Â  - const: qcom,sc7280
> > +
> >Â  Â  Â  Â  - items:
> >Â  Â  Â  Â  Â  Â  - enum:
> >Â  Â  Â  Â  Â  Â  Â  Â  - xiaomi,lavender
> > --
> > 2.17.1
> >