From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14DB8C4332F for ; Tue, 13 Dec 2022 15:06:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235183AbiLMPGe (ORCPT ); Tue, 13 Dec 2022 10:06:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235949AbiLMPGZ (ORCPT ); Tue, 13 Dec 2022 10:06:25 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23E02218A3 for ; Tue, 13 Dec 2022 07:05:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670943931; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=R9+NLd3jxdSYaQWEDRounaRV4J5+VnhfuGCpFV9Scak=; b=EUPDZqfXPFWiK2T73C/9OzleKJaNyDCqclxvAJVz7Bjb72w5HGzXhUI6yFU7C0zz9pPEjV pIvq6p9XJUMhdOHp38fUzVqrgXjTgv24NFBZdzhLqT/yQOZYIi6DZfWjOe8U6gZ9QDLiNX zNtV+EPwVeAt39x/llWDtGNyRWztPXI= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-510-99-rVDd7P4qdYEVpo9CtIw-1; Tue, 13 Dec 2022 10:05:30 -0500 X-MC-Unique: 99-rVDd7P4qdYEVpo9CtIw-1 Received: by mail-qk1-f198.google.com with SMTP id h8-20020a05620a284800b006b5c98f09fbso18021534qkp.21 for ; Tue, 13 Dec 2022 07:05:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=R9+NLd3jxdSYaQWEDRounaRV4J5+VnhfuGCpFV9Scak=; b=pDUddh09+eGqcELT+70DqabJTQ7+Tz4wju683PhqswmiNIh6f4qMS6x4ii1KcEHuEc ZOxNqIQgRS7R/3wSihnTWGT8vs6LHhQsm3PXX3OZsJYVwgD+imC6eoosGFjzAxirnHS/ 3xcRBIM6Vm++x5vXqilTpzGaGM9cS/3BzYAP2oFaZrdib0BZEYEgAU/XyqOBKJzc8TBt LXvxIEoYf3igj7bmICzXsJRtBGmOXbI1WFCSsiwQnV+d2MuiVf110jJTsW2KXTOEXfDl 5vHHcXvEHCXgzFU8F/TeBTvfaqn5y/4r8VAX9cVwVlBpw2s1DqBaOEoaBWUS+G0QTqXt Vl1A== X-Gm-Message-State: ANoB5pl+GgSU1soOLyxnssPzknWW81EQvD81DgPzj4863kTQ1+FaYf0U /4QSsX9NFH3voXnUWdJAcGRZ9EHiAYfgnDqPdQwyT9hlNpWw6vkYr7JqPNTrdJMfacRCS/HI+Mk mhcyVvtlWLMUy0P/avE7k2WvFjw== X-Received: by 2002:a05:622a:4ac6:b0:3a5:2d37:eec3 with SMTP id fx6-20020a05622a4ac600b003a52d37eec3mr29577493qtb.4.1670943921485; Tue, 13 Dec 2022 07:05:21 -0800 (PST) X-Google-Smtp-Source: AA0mqf5luC77xo0MLHMxsKzx3NKc6Ahtqb9hI1942FD7kdl7LQrB5D6dHNM0CS1pPXwf5qk8fkH5Iw== X-Received: by 2002:a05:622a:4ac6:b0:3a5:2d37:eec3 with SMTP id fx6-20020a05622a4ac600b003a52d37eec3mr29577465qtb.4.1670943921283; Tue, 13 Dec 2022 07:05:21 -0800 (PST) Received: from x1 (c-73-214-169-22.hsd1.pa.comcast.net. [73.214.169.22]) by smtp.gmail.com with ESMTPSA id p10-20020ac8740a000000b003a4f435e381sm14250qtq.18.2022.12.13.07.05.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Dec 2022 07:05:20 -0800 (PST) Date: Tue, 13 Dec 2022 10:05:19 -0500 From: Brian Masney To: Johan Hovold Cc: andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, johan+linaro@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ahalaney@redhat.com, echanude@redhat.com, quic_shazhuss@quicinc.com Subject: Re: [PATCH 1/4] arm64: dts: qcom: sc8280xp: rename i2c5 to i2c21 Message-ID: References: <20221212182314.1902632-1-bmasney@redhat.com> <20221212182314.1902632-2-bmasney@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.7 (2022-08-07) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, Dec 13, 2022 at 03:54:05PM +0100, Johan Hovold wrote: > Note that the node is labelled qup2_i2c5 and not qup_i2c5. > > That is, the QUP nodes are labelled using two indices, and specifically > > qup2_i2c5 > > would be another name for > > qup_i2c21 > > if we'd been using such a flat naming scheme (there are 8 engines per > QUP). > > So there's nothing wrong with how these nodes are currently named, but > mixing the two scheme as you are suggesting would not be correct. OK, I see; that makes sense. I'll drop this patch in v2 and fix up the new nodes accordingly. Thank you for the explanation! Brian