From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C522C3DA7A for ; Wed, 28 Dec 2022 11:54:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232999AbiL1Lyh (ORCPT ); Wed, 28 Dec 2022 06:54:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233038AbiL1Lyd (ORCPT ); Wed, 28 Dec 2022 06:54:33 -0500 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 826001114C; Wed, 28 Dec 2022 03:54:32 -0800 (PST) Received: from zn.tnic (p5de8e9fe.dip0.t-ipconnect.de [93.232.233.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 13DC11EC0513; Wed, 28 Dec 2022 12:54:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1672228471; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=uOYYomuSv/ZNzAjBnWwntCLzrOvqyqsJhfEQ6YztTh4=; b=am6pl/QVSmXjWiboBkktdRe6UQCw0kLsk3+x770O+kB3lxxda1ApgozCiyiuAxFI+CB3OE WhnDxIdvAIEKkXkRjY9jMliIbIG4gGLHKNg8KxZ7B+p2fUc21PwUPNFlVaduTW5k7U93Wq yOeNoiDv3rjIFHzKSgLJ5lE9Frn4+pY= Date: Wed, 28 Dec 2022 12:54:26 +0100 From: Borislav Petkov To: Manivannan Sadhasivam Cc: andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, tony.luck@intel.com, quic_saipraka@quicinc.com, konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, james.morse@arm.com, mchehab@kernel.org, rric@kernel.org, linux-edac@vger.kernel.org, quic_ppareek@quicinc.com, luca.weiss@fairphone.com, ahalaney@redhat.com, steev@kali.org Subject: Re: [PATCH v5 02/17] EDAC/qcom: Add platform_device_id table for module autoloading Message-ID: References: <20221228084028.46528-1-manivannan.sadhasivam@linaro.org> <20221228084028.46528-3-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221228084028.46528-3-manivannan.sadhasivam@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, Dec 28, 2022 at 02:10:13PM +0530, Manivannan Sadhasivam wrote: > platform_device_id table needs to be added so that the driver can be > autoloaded when the associated platform device gets registered. >From Documentation/process/submitting-patches.rst: "Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behaviour." IOW, "Add a device ID table so that the driver loads automatically when the associated platform_device gets registered." Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette