From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1368FC54EBC for ; Wed, 11 Jan 2023 13:28:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232228AbjAKN2Q (ORCPT ); Wed, 11 Jan 2023 08:28:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234013AbjAKN1r (ORCPT ); Wed, 11 Jan 2023 08:27:47 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE1561C931; Wed, 11 Jan 2023 05:24:51 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4AB8561A9C; Wed, 11 Jan 2023 13:24:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A4A79C433F0; Wed, 11 Jan 2023 13:24:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673443490; bh=kS5axsOZNN55F7BQL6l3Toqbtp4pQirhubS5f4MOgJU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fAZPxIE8WaQ0RA5jhkHHhHUciY5V7Wj7UaUN4luxnktIE6IvBTLwR3B21LSx6Wowb BKTee7R8cag4Gu4RznI+LMzlDio8gukgPUH59WSHdZLeb+HDjF9B/dvbJp4DK0AzSc wJX4Y8ZdNmsxVCU8M3lDTh7AxDWOBmbmkD7Jn97aiL4hASVrQ4z/nvBeiFZ3TEFmxU 66MHaEylXZX3/HVVZHrArPVaLe0UcrrF2hRqgQtKkbcijrgFzRswF2XR0oVDzCbd/c +SGDh90R5U+iFNE8QJ8QQnAfnjVji0jDlxX1YN9jHMCU/md+IBcGtwTdxpbtx1gavD yC9n4THOx7ouA== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1pFb66-00089v-RK; Wed, 11 Jan 2023 14:24:54 +0100 Date: Wed, 11 Jan 2023 14:24:54 +0100 From: Johan Hovold To: Bjorn Andersson Cc: Bjorn Andersson , Konrad Dybcio , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v7 2/4] arm64: dts: qcom: sc8280xp-crd: Enable EDP Message-ID: References: <20230111035906.2975494-1-quic_bjorande@quicinc.com> <20230111035906.2975494-3-quic_bjorande@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230111035906.2975494-3-quic_bjorande@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, Jan 10, 2023 at 07:59:04PM -0800, Bjorn Andersson wrote: > From: Bjorn Andersson > > The SC8280XP CRD has a EDP display on MDSS0 DP3, enable relevant nodes > and link it together with the backlight control. > > Signed-off-by: Bjorn Andersson > Signed-off-by: Bjorn Andersson > --- > > Changes since v6: > - None > > arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 73 ++++++++++++++++++++++- > 1 file changed, 72 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts > index 551768f97729..db12d8678861 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts > @@ -20,7 +20,7 @@ aliases { > serial0 = &qup2_uart17; > }; > > - backlight { > + backlight: backlight { > compatible = "pwm-backlight"; > pwms = <&pmc8280c_lpg 3 1000000>; > enable-gpios = <&pmc8280_1_gpios 8 GPIO_ACTIVE_HIGH>; > @@ -34,6 +34,22 @@ chosen { > stdout-path = "serial0:115200n8"; > }; > > + vreg_edp_3p3: regulator-edp-3p3 { > + compatible = "regulator-fixed"; > + > + regulator-name = "VREG_EDP_3P3"; Looks like you forgot to change this to "VCC3LCD" which should be the net name. > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + > + gpio = <&tlmm 25 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&edp_reg_en>; > + > + regulator-boot-on; > + }; > + > vreg_edp_bl: regulator-edp-bl { > compatible = "regulator-fixed"; > @@ -494,6 +559,12 @@ hastings_reg_en: hastings-reg-en-state { > &tlmm { > gpio-reserved-ranges = <74 6>, <83 4>, <125 2>, <128 2>, <154 7>; > > + edp_reg_en: edp-reg-en-state { > + pins = "gpio25"; > + function = "gpio"; > + drive-strength = <16>; 'bias-disable' as well? > + }; > + > kybd_default: kybd-default-state { > disable-pins { > pins = "gpio102"; Looks good otherwise, Reviewed-by: Johan Hovold Johan