From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41086C3DA7A for ; Mon, 2 Jan 2023 17:17:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236217AbjABRRR (ORCPT ); Mon, 2 Jan 2023 12:17:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236249AbjABRRQ (ORCPT ); Mon, 2 Jan 2023 12:17:16 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6308BC1D; Mon, 2 Jan 2023 09:17:15 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 2AF5DCE0F68; Mon, 2 Jan 2023 17:17:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 324FAC433EF; Mon, 2 Jan 2023 17:17:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672679832; bh=/eTZJkiq9bKPRQHnxXWMxz+r5NOSTNj4GpY73M58HFU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HMj9iNgwpqjSHkDndP5Md8kEvg2a8BpHkjIbwUk1L/+kWAc2jaaMvCaPFdStFrR19 YnXhG/Jki4aSWbyUhS5R6vieKdR4np/BsfqmkfSaIv1aBXm9awCzurinTzauhZa7E/ nvVW7RJa6F8TnrZ+jBFJtbfQyluJn1Zu65zMshQVKI7WbznB8pFIIB08wMAhSTDYtf 3fFvgSDlG9CnVfPy1r30d2mrwYTjHaeWmcCk1AeD84fP8W63nLbpODVAl+szh0j7zt f70XykF4CZ09zJo61UUWDb0FtOV95Ldi5DdU0kTsjsKurqVgzPCdCmXWZuYCON3Qqj ww54x+HO6UYYA== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1pCORF-00012T-Hc; Mon, 02 Jan 2023 18:17:29 +0100 Date: Mon, 2 Jan 2023 18:17:29 +0100 From: Johan Hovold To: Krzysztof Kozlowski Cc: Johan Hovold , Bjorn Andersson , Andy Gross , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Srinivas Kandagatla , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/6] arm64: dts: qcom: sc8280xp: disable sound nodes Message-ID: References: <20230102105038.8074-1-johan+linaro@kernel.org> <20230102105038.8074-3-johan+linaro@kernel.org> <82ac16e1-6c8a-b050-d627-535b4562a422@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, Jan 02, 2023 at 04:15:42PM +0100, Johan Hovold wrote: > On Mon, Jan 02, 2023 at 01:29:38PM +0100, Krzysztof Kozlowski wrote: > > On 02/01/2023 11:50, Johan Hovold wrote: > > > The sound nodes in the SoC dtsi should be disabled by default. > > > > > > Signed-off-by: Johan Hovold > > > --- > > > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 16 ++++++++++++++++ > > > 1 file changed, 16 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > > > index ed1e2bee86ee..c1ce2d7b3675 100644 > > > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > > > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > > > @@ -1733,6 +1733,8 @@ rxmacro: rxmacro@3200000 { > > > > > > pinctrl-names = "default"; > > > pinctrl-0 = <&rx_swr_default>; > > > + > > > + status = "disabled"; > > > > There is no reason this should be disabled by default. No external (per > > board) configuration is needed and by default SoC components should be > > enabled if they do not need anything from the board. > > This node is one of the nodes for which driver support is not yet in > place so that's one reason for at least disabling it temporarily. > > Since all other pinconfig lives in the board dts, if we decide to move > also the sound pinconfig then then that may be a second. Also note that these depend on q6prmcc which is in turn depends on remoteproc_adsp being enabled by the x13s dts. So keeping them disabled by default seems justified. Johan