From: Johan Hovold <johan@kernel.org>
To: Bjorn Andersson <quic_bjorande@quicinc.com>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 3/3] arm64: dts: qcom: sa8295p-adp: Add max20411 on i2c12
Date: Fri, 27 Jan 2023 10:55:21 +0100 [thread overview]
Message-ID: <Y9OfiTDwFHN0RR5G@hovoldconsulting.com> (raw)
In-Reply-To: <20230124184440.1421074-4-quic_bjorande@quicinc.com>
On Tue, Jan 24, 2023 at 10:44:40AM -0800, Bjorn Andersson wrote:
> From: Bjorn Andersson <bjorn.andersson@linaro.org>
>
> The SA8295P ADP has a Maxim max20411 step-down converter on i2c12.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
> ---
>
> Changes since v1:
> - i2c node had changed name
>
> arch/arm64/boot/dts/qcom/sa8295p-adp.dts | 41 ++++++++++++++++++++++++
> 1 file changed, 41 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sa8295p-adp.dts b/arch/arm64/boot/dts/qcom/sa8295p-adp.dts
> index bb4270e8f551..642000d95812 100644
> --- a/arch/arm64/boot/dts/qcom/sa8295p-adp.dts
> +++ b/arch/arm64/boot/dts/qcom/sa8295p-adp.dts
> @@ -266,6 +266,27 @@ &dispcc1 {
> status = "okay";
> };
>
> +&i2c12 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2c12_state>;
> +
> + status = "okay";
> +
> + vdd_gfx: regulator@39 {
Nit: Should the label be named 'vreg_gfx' (or 'vreg_vdd_gfx)') for
consistency with rest of the file?
> + compatible = "maxim,max20411";
> + reg = <0x39>;
> +
> + regulator-name = "vdd_gfx";
> + regulator-min-microvolt = <800000>;
> + regulator-max-microvolt = <968750>;
> +
> + enable-gpios = <&pmm8540a_gpios 2 GPIO_ACTIVE_HIGH>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&vdd_gfx_enable_state>;
> + };
> +};
> +
> &mdss0 {
> status = "okay";
> };
> @@ -476,6 +497,10 @@ &pcie4_phy {
> status = "okay";
> };
>
> +&qup1 {
> + status = "okay";
> +};
> +
> &qup2 {
> status = "okay";
> };
> @@ -636,7 +661,23 @@ &xo_board_clk {
>
> /* PINCTRL */
>
> +&pmm8540a_gpios {
> + vdd_gfx_enable_state: vdd-gfx-enable-state {
For consistency with the rest of sc8280xp, can you rename this
vdd_gfx_en: vdd-gfx-en-state {
(i.e. drop the 'state' from the label and shorten 'enable')?
> + pins = "gpio2";
> + function = "normal";
> + output-enable;
> + };
> +};
> +
> &tlmm {
> + i2c12_state: i2c12-state {
Similar here, this should be
i2c12_default: i2c12-default-state {
> + pins = "gpio0", "gpio1";
> + function = "qup12";
> +
And this newline can be removed.
> + drive-strength = <2>;
> + bias-pull-up;
> + };
> +
> pcie2a_default: pcie2a-default-state {
> clkreq-n-pins {
> pins = "gpio142";
Johan
next prev parent reply other threads:[~2023-01-27 9:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 18:44 [PATCH v2 0/3] regulator: Add Maxim MAX20411 support Bjorn Andersson
2023-01-24 18:44 ` [PATCH v2 1/3] regulator: dt-bindings: Describe Maxim MAX20411 Bjorn Andersson
2023-01-24 18:44 ` [PATCH v2 2/3] regulator: Introduce Maxim MAX20411 Step-Down converter Bjorn Andersson
2023-01-24 18:44 ` [PATCH v2 3/3] arm64: dts: qcom: sa8295p-adp: Add max20411 on i2c12 Bjorn Andersson
2023-01-26 22:54 ` Andrew Halaney
2023-01-26 23:35 ` Konrad Dybcio
2023-01-26 23:43 ` Andrew Halaney
2023-01-30 3:57 ` Bjorn Andersson
2023-01-27 9:55 ` Johan Hovold [this message]
2023-01-30 3:56 ` Bjorn Andersson
2023-01-26 0:29 ` [PATCH v2 0/3] regulator: Add Maxim MAX20411 support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9OfiTDwFHN0RR5G@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_bjorande@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox