From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25421C433DB for ; Thu, 21 Jan 2021 15:31:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E215D23A1E for ; Thu, 21 Jan 2021 15:31:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729690AbhAUPbR (ORCPT ); Thu, 21 Jan 2021 10:31:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732996AbhAUPat (ORCPT ); Thu, 21 Jan 2021 10:30:49 -0500 Received: from mail-oo1-xc33.google.com (mail-oo1-xc33.google.com [IPv6:2607:f8b0:4864:20::c33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6F3AC06178A for ; Thu, 21 Jan 2021 07:30:08 -0800 (PST) Received: by mail-oo1-xc33.google.com with SMTP id k9so585560oop.6 for ; Thu, 21 Jan 2021 07:30:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=yh44Qxrf3+J5SnhMnA0rx5pIze1zuLLqN86AC8WHNhk=; b=TCwTrp16z8Lztm1psaFL7rE/yVt8v+mjVp1ObImD4/Ulcik7gy/HqV3nkzD1ixdzAM eGfrFwC8tYyOzdusxgWbFYoVKjo3ZXGJp5M2rTPuEN8+Nw+L2vJtVI72tRnIAU6GvOPs ySp6f42MacoOipIl4ZSTKtRHWcogXpBaPpA9ZIQbwCXpOaxc9rK2b2zUaYw4WsP/JDT4 48PkDujOCzNMBa3W7NcFex8UUA5ySdm/aIWdXseH1yDR2SO7gKgT+5riaPUrvBuG2jOW B84VE4oGY+aM3hFfwnRibvH3ex0wfo/Pj1ekHFaGh5jegPHSSgPnO5UTTvRQ0n5Fd09x tSnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=yh44Qxrf3+J5SnhMnA0rx5pIze1zuLLqN86AC8WHNhk=; b=CYsdIWpOjsB9hU9kANU1R9EGXqDFCkP/J0AONRxZmbrkyrRgBvuYvG96SUGDUQqDpC fvrMN5PU2B4twFHR0SndsmFz8k3lUZl6Kf959ZSxaPozFzyo5yqllbjUUW+yEStzO2qb RuqdGuCDBMHC2vWpPGHE80RPas+jag8OBKAXrASho5fayiD4D8WQKLwd9zv3v986FWyc 34Id6ixJxZuW6tEABVj43gnSarKyMw6elYjpUMVdDj3l8Hgn0dKOY97BI7AFg7R0tpEz vX3bBJV6kAPT2EUNC5uxegWMUs0zxMupCvRuAp2pJWq4Wtuo+xW38k2sHjCS4zGUhz96 Mejw== X-Gm-Message-State: AOAM532QDiV07y+Jyas/c84gQaeXQ6isLNs22eaxTQ/CwON4svtv5Uh4 Elc8D/8Y7m5Ej0Trerf6U3HcWg== X-Google-Smtp-Source: ABdhPJxQHhIiYJ+qrMcAr6bi0vv2DvGBaXj8k1VbUa3szgnRbEjTRJWtS6LfZ2/eQUPXyqb5OaIG/w== X-Received: by 2002:a4a:e9a7:: with SMTP id t7mr94550ood.31.1611243008067; Thu, 21 Jan 2021 07:30:08 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id q127sm1130404oia.18.2021.01.21.07.30.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jan 2021 07:30:07 -0800 (PST) Date: Thu, 21 Jan 2021 09:30:05 -0600 From: Bjorn Andersson To: Ulf Hansson Cc: Eric Biggers , "linux-mmc@vger.kernel.org" , linux-arm-msm , Satya Tangirala , Andy Gross Subject: Re: [PATCH v5 6/9] firmware: qcom_scm: update comment for ICE-related functions Message-ID: References: <20210121090140.326380-1-ebiggers@kernel.org> <20210121090140.326380-7-ebiggers@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu 21 Jan 08:42 CST 2021, Ulf Hansson wrote: > - trimmed cc-list > > On Thu, 21 Jan 2021 at 10:03, Eric Biggers wrote: > > > > From: Eric Biggers > > > > The SCM calls QCOM_SCM_ES_INVALIDATE_ICE_KEY and > > QCOM_SCM_ES_CONFIG_SET_ICE_KEY are also needed for eMMC inline > > encryption support, not just for UFS. Update the comments accordingly. > > > > Reviewed-by: Satya Tangirala > > Signed-off-by: Eric Biggers > > Björn, may I have your ack on this one? I intend to queue this via my mmc tree. > Certainly, sorry for not paying attention. Acked-by: Bjorn Andersson And I presume I'll take the dts patch (8/9) through the Qcom tree... Regards, Bjorn > Kind regards > Uffe > > > --- > > drivers/firmware/qcom_scm.c | 16 +++++++++++----- > > 1 file changed, 11 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c > > index 7be48c1bec96d..f57779fc7ee93 100644 > > --- a/drivers/firmware/qcom_scm.c > > +++ b/drivers/firmware/qcom_scm.c > > @@ -965,8 +965,11 @@ EXPORT_SYMBOL(qcom_scm_ice_available); > > * qcom_scm_ice_invalidate_key() - Invalidate an inline encryption key > > * @index: the keyslot to invalidate > > * > > - * The UFSHCI standard defines a standard way to do this, but it doesn't work on > > - * these SoCs; only this SCM call does. > > + * The UFSHCI and eMMC standards define a standard way to do this, but it > > + * doesn't work on these SoCs; only this SCM call does. > > + * > > + * It is assumed that the SoC has only one ICE instance being used, as this SCM > > + * call doesn't specify which ICE instance the keyslot belongs to. > > * > > * Return: 0 on success; -errno on failure. > > */ > > @@ -995,10 +998,13 @@ EXPORT_SYMBOL(qcom_scm_ice_invalidate_key); > > * units, e.g. 1 = 512 bytes, 8 = 4096 bytes, etc. > > * > > * Program a key into a keyslot of Qualcomm ICE (Inline Crypto Engine), where it > > - * can then be used to encrypt/decrypt UFS I/O requests inline. > > + * can then be used to encrypt/decrypt UFS or eMMC I/O requests inline. > > + * > > + * The UFSHCI and eMMC standards define a standard way to do this, but it > > + * doesn't work on these SoCs; only this SCM call does. > > * > > - * The UFSHCI standard defines a standard way to do this, but it doesn't work on > > - * these SoCs; only this SCM call does. > > + * It is assumed that the SoC has only one ICE instance being used, as this SCM > > + * call doesn't specify which ICE instance the keyslot belongs to. > > * > > * Return: 0 on success; -errno on failure. > > */ > > -- > > 2.30.0 > >