Re: [PATCH] arm64: dts: qcom: pm8994: Add resin node to PON

[Bjorn Andersson <bjorn.andersson@linaro.org>]

On Thu 04 Feb 22:51 CST 2021, Yassine Oudjana wrote:

> On Wednesday, February 3, 2021 2:56 AM, Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
> 
> > On Tue 29 Dec 06:47 CST 2020, Yassine Oudjana wrote:
> >
> > > From: Yassine Oudjana y.oudjana@protonmail.com
> > > Date: Sun, 27 Dec 2020 21:23:40 +0400
> > > Add resin as a child node of PON.
> > >
> > > Signed-off-by: Yassine Oudjana y.oudjana@protonmail.com
> > >
> > > --------------------------------------------------------
> > >
> > > arch/arm64/boot/dts/qcom/pm8994.dtsi | 8 ++++++++
> > > 1 file changed, 8 insertions(+)
> > > diff --git a/arch/arm64/boot/dts/qcom/pm8994.dtsi b/arch/arm64/boot/dts/qcom/pm8994.dtsi
> > > index 5ffdf37d8e31..334774a38602 100644
> > > --- a/arch/arm64/boot/dts/qcom/pm8994.dtsi
> > > +++ b/arch/arm64/boot/dts/qcom/pm8994.dtsi
> > > @@ -58,6 +58,14 @@ pwrkey {
> > > linux,code = <KEY_POWER>;
> > > };
> > >
> > > -       	resin {
> > >
> > >
> > > -       		compatible = "qcom,pm8941-resin";
> > >
> > >
> > > -       		interrupts = <0x0 0x8 1 IRQ_TYPE_EDGE_BOTH>;
> > >
> > >
> > > -       		debounce = <15625>;
> > >
> > >
> > > -       		bias-pull-up;
> > >
> > >
> > > -       		linux,code = <KEY_VOLUMEDOWN>;
> > >
> > >
> >
> > Is resin always volume down?
> 
> I'm not sure, but I haven't found a device that uses it and sets it as anything else.
> 
> > Also this node is already defined in apq8096-db820c.dtsi, so how about
> > moving the common properties here, but leave it status = "disabled" and
> > then in the device specific file make it status = okay?
> 
> Sounds good. So have everything other than linux,code defined there, then
> add status = "disabled" and a label to it?
> 

Sounds good to me.

Thanks,
Bjorn

> > Regards,
> > Bjorn
> >
> > > -       	};
> > >
> > >
> > > -       };
> > >
> > >         pm8994_temp: temp-alarm@2400 {
> > >
> > >
> > >
> > > --
> > > 2.29.2