From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Andrey Konovalov <andrey.konovalov@linaro.org>
Cc: junak.pub@gmail.com, robert.foss@linaro.org,
sakari.ailus@linux.intel.com, todor.too@gmail.com,
agross@kernel.org, bjorn.andersson@linaro.org,
mchehab@kernel.org, jacopo@jmondi.org,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2.1 1/3] v4l: common: v4l2_get_link_freq: add printing a warning
Date: Sun, 21 Feb 2021 20:56:11 +0200 [thread overview]
Message-ID: <YDKsy46LhWz3BFBL@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20210218171640.18764-1-andrey.konovalov@linaro.org>
Hi Andrey,
Thank you for the patch.
On Thu, Feb 18, 2021 at 08:16:40PM +0300, Andrey Konovalov wrote:
> Print a warning if V4L2_CID_LINK_FREQ control is not implemented.
>
> Signed-off-by: Andrey Konovalov <andrey.konovalov@linaro.org>
> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/v4l2-core/v4l2-common.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/media/v4l2-core/v4l2-common.c b/drivers/media/v4l2-core/v4l2-common.c
> index 133d20e40f82..04af03285a20 100644
> --- a/drivers/media/v4l2-core/v4l2-common.c
> +++ b/drivers/media/v4l2-core/v4l2-common.c
> @@ -469,6 +469,11 @@ s64 v4l2_get_link_freq(struct v4l2_ctrl_handler *handler, unsigned int mul,
> return -ENOENT;
>
> freq = div_u64(v4l2_ctrl_g_ctrl_int64(ctrl) * mul, div);
> +
> + pr_warn("%s: Link frequency estimated using pixel rate: result might be inaccurate\n",
> + __func__);
> + pr_warn("%s: Consider implementing support for V4L2_CID_LINK_FREQ in the transmitter driver\n",
> + __func__);
It would still be nice if v4l2_ctrl_handler was extended with a struct
device pointer to use dev_warn() here, and allow replacing "the
transmitter driver" with the driver name.
> }
>
> return freq > 0 ? freq : -EINVAL;
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2021-02-21 18:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 17:16 [PATCH v2.1 1/3] v4l: common: v4l2_get_link_freq: add printing a warning Andrey Konovalov
2021-02-21 18:56 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDKsy46LhWz3BFBL@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=agross@kernel.org \
--cc=andrey.konovalov@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=jacopo@jmondi.org \
--cc=junak.pub@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robert.foss@linaro.org \
--cc=sakari.ailus@linux.intel.com \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox