From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DD80C433DB for ; Wed, 24 Feb 2021 16:56:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 482E264F04 for ; Wed, 24 Feb 2021 16:56:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235778AbhBXQ4I (ORCPT ); Wed, 24 Feb 2021 11:56:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235874AbhBXQzS (ORCPT ); Wed, 24 Feb 2021 11:55:18 -0500 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36038C06174A for ; Wed, 24 Feb 2021 08:54:35 -0800 (PST) Received: by mail-pf1-x435.google.com with SMTP id q204so651704pfq.10 for ; Wed, 24 Feb 2021 08:54:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=mmfyPvStXtF7u0Xac1+SfPR3u7qpBmzf5YppFvZBp6k=; b=jINqzVOtmNNzWHggNZ5Bcv10X2UhcxYKwtp7nqEj2Xqu/T7lRFz85XuEcxyL741K0V 0hbsSgsY6SKIxcHqzYcGQEb8fxhuLqGEZSkCOmwlzXtzaFiOhlx70adyqo7FYUwELk6r Yfo3Qt/Lgc+pQ33eDKD8fjZfsG6rPB/wkaIUo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=mmfyPvStXtF7u0Xac1+SfPR3u7qpBmzf5YppFvZBp6k=; b=UA93itpA6FUu0JJAO7FPf178OAmDkHRhb8EZ73Z48pTn3CJH72RqxwyBWhawGNe0Y2 BldRr5ghuFaEP3OK4eQ0NK0zsrXcDFcz5aTk3DaIlnfTFKO9Ix06F/c7w4utob1+HNs5 Xe340JaghhFLoeYjbbbO8a37zNZoQVFdO5l/O6TFL/UNmrykM+eOqMGVsMgIUZDZ5dfN LS4aQOktR23dezvb2hV6L6yT4MdFaPZmYzzyBsvLFNle41GM1Z5g2g4H1wEW9ax31BQv cGrFZlrbl+OLKoqtpFnMRs0mvRrwnSZOvRE4+HoAPMBl3SkXjTiLbR9uG9ma2Q7ePbbi KcqQ== X-Gm-Message-State: AOAM532u1vU5y9rL/Nk2mgIMOe3eY7YBXnFZBbLZc9fMnhUwMmDDu9lO f6jqFps0Ehlpng4uMloD0CPphA== X-Google-Smtp-Source: ABdhPJyaV2heBCie+AEicWXVBCE1Unoh7KiztvFLYltPpJsjq0Q7+hHKPCZdRigJeDE/wxKC/GYfow== X-Received: by 2002:a65:4508:: with SMTP id n8mr26645153pgq.294.1614185674794; Wed, 24 Feb 2021 08:54:34 -0800 (PST) Received: from localhost ([2620:15c:202:1:9f5:1448:883f:b01]) by smtp.gmail.com with UTF8SMTPSA id v3sm3199593pff.217.2021.02.24.08.54.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Feb 2021 08:54:34 -0800 (PST) Date: Wed, 24 Feb 2021 08:54:32 -0800 From: Matthias Kaehlcke To: Dmitry Baryshkov Cc: Andy Gross , Bjorn Andersson , Rob Herring , "open list:DRM DRIVER FOR MSM ADRENO GPU" , open list , Douglas Anderson , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Subject: Re: [PATCH 3/3] arm64: dts: qcom: sc7180: Delete charger thermal zone and ADC channel for lazor <= rev3 Message-ID: References: <20210219181032.1.I23e12818c4a841ba9c37c60b3ba8cfeeb048285f@changeid> <20210219181032.3.Ia4c1022191d09fe8c56a16486b77796b83ffcae4@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, Feb 23, 2021 at 02:12:30PM +0300, Dmitry Baryshkov wrote: > Hi, > > On Sat, 20 Feb 2021 at 05:13, Matthias Kaehlcke wrote: > > > > Lazor rev3 and older are stuffed with a 47k NTC as thermistor for > > the charger temperature which currently isn't supported by the > > PM6150 ADC driver. Delete the charger thermal zone and ADC channel > > to avoid the use of bogus temperature values. > > Should we just expand the adc/adc-tm drivers with additional calibration tables? Generally that seems desirable, I'm not sure about the process, I guess someone with access to a climate chamber would have to create these tables? I think it would also require an extension of the DT bindings, currently the ADC driver assumes that a 100k NTC is connected, something in the DT would have to indicate the thermistor type. We want to remove the bogus temperatures from the system now, if support for 47k NTCs is added at some point we can consider changing the DT again.