From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46C55C433E0 for ; Wed, 10 Mar 2021 12:10:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EAAB164FE5 for ; Wed, 10 Mar 2021 12:10:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233010AbhCJMKK (ORCPT ); Wed, 10 Mar 2021 07:10:10 -0500 Received: from mga11.intel.com ([192.55.52.93]:34965 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232758AbhCJMJz (ORCPT ); Wed, 10 Mar 2021 07:09:55 -0500 IronPort-SDR: 2CEV/w878rDxhUzRWpJGKOzmVf/F0oeXSD4a6zSmY7V8AlxfvQcceYJ+ur0W5BSOhztXkHQ/j+ 4UGIcW6S9mjg== X-IronPort-AV: E=McAfee;i="6000,8403,9917"; a="185096046" X-IronPort-AV: E=Sophos;i="5.81,237,1610438400"; d="scan'208";a="185096046" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2021 04:09:55 -0800 IronPort-SDR: LO774NGduKoLLyq6YR0XAm1dDQySwDGAzMkWAOyMEGPE3XBT3StFoVBdHJm2Rl4y22AWFVqHjJ Hr8Vtx4Cp1rA== X-IronPort-AV: E=Sophos;i="5.81,237,1610438400"; d="scan'208";a="509644591" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2021 04:09:53 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lJxex-00BJkG-BE; Wed, 10 Mar 2021 14:09:51 +0200 Date: Wed, 10 Mar 2021 14:09:51 +0200 From: Andy Shevchenko To: Shawn Guo Cc: Linus Walleij , Bjorn Andersson , linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v4] pinctrl: qcom: sc8180x: add ACPI probe support Message-ID: References: <20210310111210.1232-1-shawn.guo@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210310111210.1232-1-shawn.guo@linaro.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, Mar 10, 2021 at 07:12:10PM +0800, Shawn Guo wrote: > It adds ACPI probe support for pinctrl-sc8180x driver. We have one > problem with ACPI table, i.e. GIO0 (TLMM) block has one single memory > resource to cover 3 tiles defined by SC8180X. To follow the hardware > layout of 3 tiles which is already supported DT probe, it adds one > function to replace the original single memory resource with 3 named > ones for tiles. With that, We can map memory for ACPI in the same way > as DT. You are reinventing a wheel, i.e. MFD framework. Can you simple utilize devm_mfd_add_devices()? Basically you may write an new pure MFD driver (drivers/mfd) that will instantiate properly the pin control driver. -- With Best Regards, Andy Shevchenko