From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46056C433E0 for ; Thu, 11 Mar 2021 09:12:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F1F9964FB8 for ; Thu, 11 Mar 2021 09:12:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231925AbhCKJMN (ORCPT ); Thu, 11 Mar 2021 04:12:13 -0500 Received: from mga02.intel.com ([134.134.136.20]:54642 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230158AbhCKJLz (ORCPT ); Thu, 11 Mar 2021 04:11:55 -0500 IronPort-SDR: CJPwHRFlCMTxV+1XzzbSTyNr/tk14Q7XvhvY3lvc7/Atdb/uIZ9TdivkWcH5LWUvVeTJ2R8zgK ifCW/qEFa48A== X-IronPort-AV: E=McAfee;i="6000,8403,9919"; a="175751156" X-IronPort-AV: E=Sophos;i="5.81,239,1610438400"; d="scan'208";a="175751156" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2021 01:11:49 -0800 IronPort-SDR: Tpw6Dvx3s1M7gsZcr+qTNJa41P1Nw4KiWeyLrplpiXt54IjH0snVCCuyPm0rriYRiRl/G2jmlq NpRjeKFAsdNg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,239,1610438400"; d="scan'208";a="509967596" Received: from kuha.fi.intel.com ([10.237.72.162]) by fmsmga001.fm.intel.com with SMTP; 11 Mar 2021 01:11:45 -0800 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Thu, 11 Mar 2021 11:11:43 +0200 Date: Thu, 11 Mar 2021 11:11:43 +0200 From: Heikki Krogerus To: Shawn Guo Cc: Felipe Balbi , Bjorn Andersson , Greg Kroah-Hartman , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH] Revert "usb: dwc3: qcom: Constify the software node" Message-ID: References: <20210311090049.7354-1-shawn.guo@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210311090049.7354-1-shawn.guo@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, Mar 11, 2021 at 05:00:49PM +0800, Shawn Guo wrote: > This reverts commit 8dc6e6dd1bee39cd65a232a17d51240fc65a0f4a. > > The commit causes an regression for ACPI probe on Lenovo Yoga C630 > laptop. platform_device_add_properties() will fail with -EEXIST for the > second USB instance, because of the software_node_to_swnode() check in > function software_node_register(). I think you mean device_add_software_node() fails with -EEXIST, no? There should be already a fix for that: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=linux-next&id=2a92c90f2ecca4475d6050f2f93 +8a1755a8954cc thanks, -- heikki