From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A6B5C433E0 for ; Tue, 30 Mar 2021 13:33:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2AE56619C7 for ; Tue, 30 Mar 2021 13:33:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231803AbhC3NdT (ORCPT ); Tue, 30 Mar 2021 09:33:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:57404 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230369AbhC3Nc4 (ORCPT ); Tue, 30 Mar 2021 09:32:56 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 88CD9619AA; Tue, 30 Mar 2021 13:32:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617111176; bh=OSmVIm9h53ibzErSO90gLnQz6mMJrRbgf57AdcadAxQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GoaQ6tu2QYKqlgiGL2RXYmpqYlqnKbJi9x45swO8sknTBEBDp8abg50enLGve9bA8 WAX5kV0i/xHx/2gYEv7MNks0TD5Sg/EYw5ZVIU0F4GmJH5lXs76sF33Na3bKh3sFwU FGA+9pVVFd+S+tj95pQ68a27t6vV2bwQhlBlNmlg= Date: Tue, 30 Mar 2021 15:32:53 +0200 From: Greg Kroah-Hartman To: Sai Prakash Ranjan Cc: Sandeep Maheswaram , Felipe Balbi , Stephen Boyd , Doug Anderson , Matthias Kaehlcke , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Manu Gautam Subject: Re: [PATCH v1] usb: dwc3: core: Add shutdown callback for dwc3 Message-ID: References: <1616527652-7937-1-git-send-email-sanm@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, Mar 30, 2021 at 06:18:43PM +0530, Sai Prakash Ranjan wrote: > On 2021-03-30 16:46, Greg Kroah-Hartman wrote: > > On Tue, Mar 30, 2021 at 03:25:58PM +0530, Sai Prakash Ranjan wrote: > > > On 2021-03-30 14:37, Greg Kroah-Hartman wrote: > > > > On Tue, Mar 30, 2021 at 02:12:04PM +0530, Sandeep Maheswaram wrote: > > > > > > > > > > On 3/26/2021 7:07 PM, Greg Kroah-Hartman wrote: > > > > > > On Wed, Mar 24, 2021 at 12:57:32AM +0530, Sandeep Maheswaram wrote: > > > > > > > This patch adds a shutdown callback to USB DWC core driver to ensure that > > > > > > > it is properly shutdown in reboot/shutdown path. This is required > > > > > > > where SMMU address translation is enabled like on SC7180 > > > > > > > SoC and few others. If the hardware is still accessing memory after > > > > > > > SMMU translation is disabled as part of SMMU shutdown callback in > > > > > > > system reboot or shutdown path, then IOVAs(I/O virtual address) > > > > > > > which it was using will go on the bus as the physical addresses which > > > > > > > might result in unknown crashes (NoC/interconnect errors). > > > > > > > > > > > > > > Previously this was added in dwc3 qcom glue driver. > > > > > > > https://patchwork.kernel.org/project/linux-arm-msm/list/?series=382449 > > > > > > > But observed kernel panic as glue driver shutdown getting called after > > > > > > > iommu shutdown. As we are adding iommu nodes in dwc core node > > > > > > > in device tree adding shutdown callback in core driver seems correct. > > > > > > So shouldn't you also remove this from the qcom glue driver at the same > > > > > > time? Please submit both as a patch series. > > > > > > > > > > > > thanks, > > > > > > > > > > > > greg k-h > > > > > > > > > > Hi Greg, > > > > > > > > > > The qcom glue driver patch is not merged yet. I have just mentioned > > > > > for it for reference. > > > > > > > > You know that we can not add callbacks for no in-kernel user, so what > > > > good is this patch for now? > > > > > > > > > > What in-kernel user? Since when does shutdown callback need an > > > in-kernel > > > user? When you reboot or shutdown a system, it gets called. The reason > > > why the shutdown callback is needed is provided in the commit text. > > > > As I can't see the patch here, I have no idea... > > You are replying now to the same patch which adds this shutdown callback :) > Anyways the qcom dwc3 driver patch which is abandoned which is also > mentioned > in the commit text is here [1] and the new shutdown callback patch which we > are both replying to is in here [2] > > [1] https://lore.kernel.org/lkml/1605162619-10064-1-git-send-email-sanm@codeaurora.org/ > > [2] https://lore.kernel.org/lkml/1616527652-7937-1-git-send-email-sanm@codeaurora.org/ Thanks, so, what am I supposed to do here? The patch is long gone from my queue... greg k-h