From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CE26C47082 for ; Sun, 6 Jun 2021 02:19:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6149261260 for ; Sun, 6 Jun 2021 02:19:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230050AbhFFCVP (ORCPT ); Sat, 5 Jun 2021 22:21:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230022AbhFFCVO (ORCPT ); Sat, 5 Jun 2021 22:21:14 -0400 Received: from mail-ot1-x329.google.com (mail-ot1-x329.google.com [IPv6:2607:f8b0:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B52C5C061766 for ; Sat, 5 Jun 2021 19:19:10 -0700 (PDT) Received: by mail-ot1-x329.google.com with SMTP id c31-20020a056830349fb02903a5bfa6138bso13179244otu.7 for ; Sat, 05 Jun 2021 19:19:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=zNbv9BC90PSJK3BiNVtXp/UlQ672WKw22htu3kgy/xM=; b=gXkbatGIEAUci3gDLrgIoLjjvULz58IuKuFxT4SXxR8pUL+uUfgpyyOszQAdBoZYEB sDDxMs9ainspWj83epDN0ouSPk5pqY3JkdigsULIszryyPv9jdYUyvC1p7ZYx1xTVXmi N+8l8PhCdbWRBDZOiKJTgKNt1T+xV3cY9qw/m2RcRnTM/UlFOKj/GgVNVMzdZn7TUN/B SwoY4cs2RaQqifbdQ5qysb31CH3Pxrp74KbwnoxfCEV5OL2qy9udGdrQ31jjgzjwQPTi bZpv2e4E6diBMNZavH29MJzPj/OrxfVhExmqbKttKOtW6PzkLvDhFhXYsAOhWx/xC21/ vzPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zNbv9BC90PSJK3BiNVtXp/UlQ672WKw22htu3kgy/xM=; b=KdR50ioMe1m6EC+FIgGgFhF5OsRV2etO6mHK1X1P9QMjp1a6McEOrm/HrFl0AKYG0N AyGF72BHz9AS3C+SFPLh//C74vQBjYJB7VgeyaZIlr+OqwDjdVkileNA1qsVroq1GpZh AsBylp9KYGLpETiStHAvEP93miqqDS6edV5gbJqNDDANEE03vOaPXwejE46PG+dxKcIb GjnlSaPzcZoudlwAFX/DZiwyXX4mDnZG0gYIN0m58OHPmSszcu9YFH+vnaBM67ynQr0T dq9++6s63u0bTYCXVmxr3uzK/WYqq6A8OsD9NZ1K58810FgyvP7BDL78YhUEiq9hp2SK STrg== X-Gm-Message-State: AOAM531/sTOoOwy+7IHfrW6/EzG/vPgxWQ6gWRxp5S5lGT3vNPPcDutc GH510kYpg1YocwtiiE22WGmBCQ== X-Google-Smtp-Source: ABdhPJxTktQPJ2z1NLgZoKM9jhvO1dJthPs9wgI4awNl/O4GyFHikQZtAp9jV330wRFlPKHe4KpiKw== X-Received: by 2002:a05:6830:1e0d:: with SMTP id s13mr9231932otr.169.1622945949970; Sat, 05 Jun 2021 19:19:09 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id n11sm1390698oom.1.2021.06.05.19.19.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Jun 2021 19:19:09 -0700 (PDT) Date: Sat, 5 Jun 2021 21:19:07 -0500 From: Bjorn Andersson To: Prasad Malisetty Cc: agross@kernel.org, bhelgaas@google.com, robh+dt@kernel.org, swboyd@chromium.org, lorenzo.pieralisi@arm.com, svarbanov@mm-sol.com, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, mgautam@codeaurora.org, dianders@chromium.org, mka@chromium.org, sanm@codeaurora.org Subject: Re: [PATCH v2 4/4] dt-bindings: pci: qcom: Document PCIe bindings for SC720 Message-ID: References: <1622904059-21244-1-git-send-email-pmaliset@codeaurora.org> <1622904059-21244-5-git-send-email-pmaliset@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1622904059-21244-5-git-send-email-pmaliset@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Sat 05 Jun 09:40 CDT 2021, Prasad Malisetty wrote: > Document the PCIe DT bindings for SC7280 SoC.The PCIe IP is similar > to the one used on SM8250. Add the compatible for SC7280. > > Signed-off-by: Prasad Malisetty > Acked-by: Rob Herring > --- > Documentation/devicetree/bindings/pci/qcom,pcie.txt | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.txt b/Documentation/devicetree/bindings/pci/qcom,pcie.txt > index 25f4def..9c0908f 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.txt > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.txt > @@ -12,6 +12,7 @@ > - "qcom,pcie-ipq4019" for ipq4019 > - "qcom,pcie-ipq8074" for ipq8074 > - "qcom,pcie-qcs404" for qcs404 > + - "qcom,pcie-sc7280" for sc7280 > - "qcom,pcie-sdm845" for sdm845 > - "qcom,pcie-sm8250" for sm8250 > - "qcom,pcie-ipq6018" for ipq6018 > @@ -144,6 +145,22 @@ > - "slave_bus" AXI Slave clock > > - clock-names: > + Usage: required for sc7280 > + Value type: > + Definition: Should contain the following entries > + - "aux" Auxiliary clock > + - "cfg" Configuration clock > + - "bus_master" Master AXI clock > + - "bus_slave" Slave AXI clock > + - "slave_q2a" Slave Q2A clock > + - "tbu" PCIe TBU clock > + - "ddrss_sf_tbu" PCIe SF TBU clock > + - "pipe" PIPE clock > + - "pipe_src" PIPE MUX If you describe it as pipe _mux_, then name it pipe_mux. > + - "pipe_ext" PIPE output clock Better to name this in a way that indicates that it is the pipe clock coming out of the phy, perhaps "phy_pipe". But that said, as Stephen points out ensuring that the pipe_clk_src's parent is the phy's clock can be done in DT directly. Regards, Bjorn > + - "ref" REFERENCE clock > + > +- clock-names: > Usage: required for sdm845 > Value type: > Definition: Should contain the following entries > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >