From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D5A5C4320A for ; Fri, 30 Jul 2021 18:00:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 255BB60F94 for ; Fri, 30 Jul 2021 18:00:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230374AbhG3SAy (ORCPT ); Fri, 30 Jul 2021 14:00:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230327AbhG3SAx (ORCPT ); Fri, 30 Jul 2021 14:00:53 -0400 Received: from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com [IPv6:2607:f8b0:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B353C06175F for ; Fri, 30 Jul 2021 11:00:48 -0700 (PDT) Received: by mail-ot1-x32c.google.com with SMTP id c2-20020a0568303482b029048bcf4c6bd9so10383716otu.8 for ; Fri, 30 Jul 2021 11:00:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=wKcp94SXlzIL+rKCJfhPFUl8LwJ46IN+eIJM4QxPZ7Y=; b=EIHXCA0v5HstLP8hONQu8hfyiem8F2OPnEU12vCIXh/sEG7ViYP2/eNlFr4qce/DvY opBMGdlt5DgiSconUiX4fUNfVtnhFxxMOeOtk0D16LIjqHr3WAjtOBtXaPpk7qlHlZvy Zl7NKWloBgA6t0FMJK4jJTMo4Q5KycaUkVVsNqPi5VsysqdtP3UEroZANW3nEVYgWb0v EEVcZ5k+y11FysJUAJJLjiP68P0SNdVYMm2note2FhgLoUDg0TH4mihG8Z+NDW6GiyKP 7m2kbVSWI0zKYntLcB+qREW5oqPt1wdQKHthhZ0cdvMiJs8gjEQI59q1so2vyNrsofRP Zy3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wKcp94SXlzIL+rKCJfhPFUl8LwJ46IN+eIJM4QxPZ7Y=; b=gTLsXc7/cv7ZDr5ukiYNaYzbxqZc8caPyDI+2gum+WrEGs1y5IQQifHNGjFuoFnnne UgqqyvCNQh3PDORYCnc1Am+GM+VRMsIDRz4euMn1kH4RlwUbacLhmgZFDn3LHwHQe8TR GG9t5k4wsRMqGYMbnfqpvxIOyfWBxxcvZWB/WXXASDBNjQbjK1w4FKqfLmsZXLWmlMoa Ziz6yUIK01Kgbv5QGRJbgPCrj00CTvQAerJp3OMCMsDnNQXAtFCmlp5ClLhw4v2rXcG/ mpolIdjcuit8Lb6urrOJ6xz+bCvmna7DlKcAgWD6osRl0wsMMB6sXUFdcFQleKOtkWMy nlbA== X-Gm-Message-State: AOAM530+Cf5kWYbTnh2skTcUSn+Os7ZqPiB0Jv0EGzNLO9eNKokoD9uk TpV/L58Pl45AQ6OLDNiXTuZR3Q== X-Google-Smtp-Source: ABdhPJyXm3/c/DZWJx3M2wBcbj3susmf4EJpEeDHUy1dhDVv4ayHUWMRlCgXopkCSWt+HrWBQd08cg== X-Received: by 2002:a05:6830:114f:: with SMTP id x15mr2924468otq.356.1627668047529; Fri, 30 Jul 2021 11:00:47 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id b16sm402742otl.59.2021.07.30.11.00.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jul 2021 11:00:46 -0700 (PDT) Date: Fri, 30 Jul 2021 13:00:44 -0500 From: Bjorn Andersson To: Sibi Sankar Cc: robh+dt@kernel.org, will@kernel.org, saiprakash.ranjan@codeaurora.org, ohad@wizery.com, agross@kernel.org, mathieu.poirier@linaro.org, robin.murphy@arm.com, joro@8bytes.org, p.zabel@pengutronix.de, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, evgreen@chromium.org, dianders@chromium.org, swboyd@chromium.org Subject: Re: [PATCH 7/9] arm64: dts: qcom: sc7280: Add nodes to boot modem Message-ID: References: <1624564058-24095-1-git-send-email-sibis@codeaurora.org> <1624564058-24095-8-git-send-email-sibis@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1624564058-24095-8-git-send-email-sibis@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu 24 Jun 14:47 CDT 2021, Sibi Sankar wrote: > Add miscellaneous nodes to boot the modem and support post-mortem debug > on SC7280 SoCs. > > Signed-off-by: Sibi Sankar > --- > arch/arm64/boot/dts/qcom/sc7280.dtsi | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi > index 5ed7a511bfc9..3fb6a6ef39f8 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > @@ -547,6 +547,11 @@ > #hwlock-cells = <1>; > }; > > + tcsr_regs: syscon@1fc0000 { Is there a different "tcsr"? Does the "_regs" suffix add any value? > + compatible = "syscon"; Rob has pointed out a few times that a lone "syscon" isn't going to be accepted going forward. Could you also add a qualifying "qcom,sc7280-tcsr" or something like that? > + reg = <0 0x01fc0000 0 0x30000>; > + }; > + > lpasscc: lpasscc@3000000 { > compatible = "qcom,sc7280-lpasscc"; > reg = <0 0x03000000 0 0x40>, > @@ -1219,6 +1224,21 @@ > }; > }; > > + imem@146aa000 { > + compatible = "syscon", "simple-mfd"; As above "qcom,sc7280-imem"? I presume we need some new binding documents for these two though, perhaps you can add the specific compatibles and we agree that one of us will write these two bindings soon? Regards, Bjorn > + reg = <0 0x146aa000 0 0x2000>; > + > + #address-cells = <2>; > + #size-cells = <2>; > + > + ranges = <0 0x0 0 0x146aa000 0 0x2000>; > + > + pil-reloc@94c { > + compatible = "qcom,pil-reloc-info"; > + reg = <0 0x94c 0 0xc8>; > + }; > + }; > + > apps_smmu: iommu@15000000 { > compatible = "qcom,sc7280-smmu-500", "arm,mmu-500"; > reg = <0 0x15000000 0 0x100000>; > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >