From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Antonio Martorana <amartora@codeaurora.org>
Cc: Andy Gross <agross@kernel.org>,
Elliot Berman <quic_eberman@quicinc.com>,
Trilok Soni <tsoni@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc: qcom: socinfo: Fixed argument passed to platform_set_data()
Date: Mon, 16 Aug 2021 21:35:33 -0500 [thread overview]
Message-ID: <YRsgdXv749tznl2i@yoga> (raw)
In-Reply-To: <1629159879-95777-1-git-send-email-amartora@codeaurora.org>
On Mon 16 Aug 19:24 CDT 2021, Antonio Martorana wrote:
> Set qcom_socinfo pointer as data being stored instead of pointer
> to soc_device structure. Aligns with future calls to platform_get_data()
> which expects qcom_socinfo pointer.
>
Thanks for the patch Antonio!
This should have a fixes tag, to ensure that it's appropriately
backported.
Fixes: efb448d0a3fc ("soc: qcom: Add socinfo driver")
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> Signed-off-by: Antonio Martorana <amartora@codeaurora.org>
> ---
> drivers/soc/qcom/socinfo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
> index 9faf483..52e5811 100644
> --- a/drivers/soc/qcom/socinfo.c
> +++ b/drivers/soc/qcom/socinfo.c
> @@ -628,7 +628,7 @@ static int qcom_socinfo_probe(struct platform_device *pdev)
> /* Feed the soc specific unique data into entropy pool */
> add_device_randomness(info, item_size);
>
> - platform_set_drvdata(pdev, qs->soc_dev);
> + platform_set_drvdata(pdev, qs);
>
> return 0;
> }
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
prev parent reply other threads:[~2021-08-17 2:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 0:24 [PATCH] soc: qcom: socinfo: Fixed argument passed to platform_set_data() Antonio Martorana
2021-08-17 2:35 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRsgdXv749tznl2i@yoga \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=amartora@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_eberman@quicinc.com \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox