Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jeya R <jeyr@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, srinivas.kandagatla@linaro.org,
	linux-kernel@vger.kernel.org, fastrpc.upstream@qti.qualcomm.com
Subject: Re: [PATCH] [PATCH v2] misc: fastrpc: fix improper packet size calculation
Date: Tue, 21 Sep 2021 13:32:19 +0200	[thread overview]
Message-ID: <YUnCw4uCSd1O7QX0@kroah.com> (raw)
In-Reply-To: <1632221847-987-1-git-send-email-jeyr@codeaurora.org>

On Tue, Sep 21, 2021 at 04:27:27PM +0530, Jeya R wrote:
> The buffer list is sorted and this is not being considered while
> calculating packet size. This would lead to improper copy length
> calculation for non-dmaheap buffers which would eventually cause
> sending improper buffers to DSP.
> 
> Fixes: c68cfb718c8f ("misc: fastrpc: Add support for context Invoke method")
> Signed-off-by: Jeya R <jeyr@codeaurora.org>
> 
> Changes in v2:
> - updated commit message to proper format
> - added fixes tag to commit message
> - removed unnecessary variable initialization
> - removed length check during payload calculation
> ---
>  drivers/misc/fastrpc.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)

The "Changes" need to go below the --- line, as the documentation states
to do.

thanks,

greg k-h

  parent reply	other threads:[~2021-09-21 11:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-21 10:57 [PATCH] [PATCH v2] misc: fastrpc: fix improper packet size calculation Jeya R
2021-09-21 11:14 ` Srinivas Kandagatla
2021-09-21 11:32 ` Greg KH [this message]
2021-09-21 11:35   ` jeyr
2021-09-21 11:41     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YUnCw4uCSd1O7QX0@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=fastrpc.upstream@qti.qualcomm.com \
    --cc=jeyr@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox