From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C840C433F5 for ; Tue, 5 Oct 2021 10:37:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 717186124F for ; Tue, 5 Oct 2021 10:37:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233490AbhJEKji (ORCPT ); Tue, 5 Oct 2021 06:39:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:35438 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232723AbhJEKjh (ORCPT ); Tue, 5 Oct 2021 06:39:37 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 77BAD6124F; Tue, 5 Oct 2021 10:37:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633430267; bh=Wv/SF6G50tw+P67CaN7frd0E2WbmInm7Ve/ayZJ5bdA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ik9VseNoVdNFMsjnX5croDf4AaLO02QYa4ZHgBBTEK4vialF2XDUjVBR3chww9IPJ EtL4IHhBhjr5x9n7g6Se7z7JxiTuQDpGUR/EOuySmF2D6aEGIbfkq84ae8QoZbyd6C 9OsL4GispnTdlj2f9nXb8PwJCslOTavI1InLY2bxlXIQZ11+bSp3PX2LXmwx4tpj4V ZNDfTGphTM+gmFvP+p4Z0yPAMf07YM60o+jvawp/3g0T7hoR6150A9NtYjvVU6a9kk 2zZk5kC6x04prVWqm2dGsOOwOoDIJCjY2Op9VpYDtT+Z0d+7ZNv4OMCAyd7BhWPR54 YV4oLM0Vok8+w== Date: Tue, 5 Oct 2021 16:07:43 +0530 From: Vinod Koul To: Vladimir Zapolskiy Cc: Bjorn Andersson , Andy Gross , Kishon Vijay Abraham I , Vivek Gautam , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org Subject: Re: [PATCH v2] phy: qcom-qusb2: Fix a memory leak on probe Message-ID: References: <20210922233548.2150244-1-vladimir.zapolskiy@linaro.org> <56c4530b-2f66-f325-b703-e58e90c3c66a@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56c4530b-2f66-f325-b703-e58e90c3c66a@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 01-10-21, 14:04, Vladimir Zapolskiy wrote: > On 10/1/21 12:42 PM, Vinod Koul wrote: > > On 23-09-21, 02:35, Vladimir Zapolskiy wrote: > > > On success nvmem_cell_read() returns a pointer to a dynamically allocated > > > buffer, and therefore it shall be freed after usage. > > > > > > The issue is reported by kmemleak: > > > > > > # cat /sys/kernel/debug/kmemleak > > > unreferenced object 0xffff3b3803e4b280 (size 128): > > > comm "kworker/u16:1", pid 107, jiffies 4294892861 (age 94.120s) > > > hex dump (first 32 bytes): > > > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > > > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > > > backtrace: > > > [<000000007739afdc>] __kmalloc+0x27c/0x41c > > > [<0000000071c0fbf8>] nvmem_cell_read+0x40/0xe0 > > > [<00000000e803ef1f>] qusb2_phy_init+0x258/0x5bc > > > [<00000000fc81fcfa>] phy_init+0x70/0x110 > > > [<00000000e3d48a57>] dwc3_core_soft_reset+0x4c/0x234 > > > [<0000000027d1dbd4>] dwc3_core_init+0x68/0x990 > > > [<000000001965faf9>] dwc3_probe+0x4f4/0x730 > > > [<000000002f7617ca>] platform_probe+0x74/0xf0 > > > [<00000000a2576cac>] really_probe+0xc4/0x470 > > > [<00000000bc77f2c5>] __driver_probe_device+0x11c/0x190 > > > [<00000000130db71f>] driver_probe_device+0x48/0x110 > > > [<0000000019f36c2b>] __device_attach_driver+0xa4/0x140 > > > [<00000000e5812ff7>] bus_for_each_drv+0x84/0xe0 > > > [<00000000f4bac574>] __device_attach+0xe4/0x1c0 > > > [<00000000d3beb631>] device_initial_probe+0x20/0x30 > > > [<000000008019b9db>] bus_probe_device+0xa4/0xb0 > > > > > > Fixes: ca04d9d3e1b1 ("phy: qcom-qusb2: New driver for QUSB2 PHY on Qcom chips") > > > Signed-off-by: Vladimir Zapolskiy > > > --- > > > Changes from v1 to v2: > > > * fixed a memory leak in case of reading a zero value and return, > > > * corrected the fixed commit, the memory leak is present before a rename. > > > > > > drivers/phy/qualcomm/phy-qcom-qusb2.c | 16 ++++++++++------ > > > 1 file changed, 10 insertions(+), 6 deletions(-) > > > > > > diff --git a/drivers/phy/qualcomm/phy-qcom-qusb2.c b/drivers/phy/qualcomm/phy-qcom-qusb2.c > > > index 3c1d3b71c825..f1d97fbd1331 100644 > > > --- a/drivers/phy/qualcomm/phy-qcom-qusb2.c > > > +++ b/drivers/phy/qualcomm/phy-qcom-qusb2.c > > > @@ -561,7 +561,7 @@ static void qusb2_phy_set_tune2_param(struct qusb2_phy *qphy) > > > { > > > struct device *dev = &qphy->phy->dev; > > > const struct qusb2_phy_cfg *cfg = qphy->cfg; > > > - u8 *val; > > > + u8 *val, hstx_trim; > > > /* efuse register is optional */ > > > if (!qphy->cell) > > > @@ -575,7 +575,13 @@ static void qusb2_phy_set_tune2_param(struct qusb2_phy *qphy) > > > * set while configuring the phy. > > > */ > > > val = nvmem_cell_read(qphy->cell, NULL); > > > - if (IS_ERR(val) || !val[0]) { > > > + if (IS_ERR(val)) { > > > + dev_dbg(dev, "failed to read a valid hs-tx trim value\n"); > > > > not an error log..? > > > > It's a copy from the existing code, no changes on error but the memory leak fix. > > If CONFIG_NVMEM is not set, then nvmem_cell_read() returns ERR_PTR(-EOPNOTSUPP), > still it allows to build/run the phy driver, so it seems to be a valid option, > please correct me. Yes it is not relevant to the leak fix here, so I will apply it -- ~Vinod