From: Mark Brown <broonie@kernel.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Judy Hsiao <judyhsiao@chromium.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Banajit Goswami <bgoswami@codeaurora.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
dianders@chromium.org, cychiang@google.com, judyhsiao@google.com,
linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH] SoC: qcom: Distinguish headset codec by codec_dai->name
Date: Mon, 13 Dec 2021 18:00:35 +0000 [thread overview]
Message-ID: <YbeKQ3mLqe1RoUWJ@sirena.org.uk> (raw)
In-Reply-To: <CAE-0n52z=wRS3rXM=zQzcy1yryvzwW6iGA75UYBiYSkR_5edTA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1131 bytes --]
On Fri, Dec 10, 2021 at 03:15:49PM -0800, Stephen Boyd wrote:
> Quoting Judy Hsiao (2021-12-09 21:19:07)
> > Fixes: 425c5fce8a03 ("ASoC: qcom: Add support for ALC5682I-VS codec")
> It fixes something so what is it fixing? Can you add the call stack of
> the failure and explain how this patch fixes it? We have that patch
> backported to our chromeos 5.4 kernel tree but I assume this reproduces
> upstream.
Please don't encourage people to just paste entire panics into things,
what you've included here is vastly larger than the entire original
patch which overwhelms the content in the message.
> Unable to handle kernel paging request at virtual address ffffffbfe7bba9ce
> Mem abort info:
> ESR = 0x96000005
> EC = 0x25: DABT (current EL), IL = 32 bits
> SET = 0, FnV = 0
> EA = 0, S1PTW = 0
> Data abort info:
> ISV = 0, ISS = 0x00000005
> CM = 0, WnR = 0
Information like the above or the register contents is not adding any
value here, it just makes it harder to find the actual content in the
message. Sometimes a relevant portion of the stack can be useful but
that's not what's happening here.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2021-12-13 18:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 5:19 [PATCH] SoC: qcom: Distinguish headset codec by codec_dai->name Judy Hsiao
2021-12-10 23:15 ` Stephen Boyd
2021-12-13 18:00 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbeKQ3mLqe1RoUWJ@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=cychiang@google.com \
--cc=dianders@chromium.org \
--cc=judyhsiao@chromium.org \
--cc=judyhsiao@google.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=perex@perex.cz \
--cc=srinivas.kandagatla@linaro.org \
--cc=swboyd@chromium.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox