Re: [PATCH V3 3/7] bindings: usb: dwc3: Update dwc3 properties for EUD connector

Souradeep Chowdhury
2022-01-17T05:09:23Z

On 1/7/2022 6:26 AM, Bjorn Andersson wrote:
> On Tue 04 Jan 03:58 PST 2022, Souradeep Chowdhury wrote:
>
>> Add the connector property for dwc3 node. This connector can
>> be used to role-switch the controller from device to host and
>> vice versa.
>>
>> Signed-off-by: Souradeep Chowdhury <quic_schowdhu@quicinc.com>
>> ---
>> Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
>> index 078fb78..9382168 100644
>> --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
>> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
>> @@ -318,6 +318,12 @@ properties:
>> items:
>> enum: [1, 4, 8, 16, 32, 64, 128, 256]
>>
>> + connector:
> The dwc3 isn't the connector, so I think you should put a ports {} in
> the dwc3 and link that to the connector that is described elsewhere.
Ack
> Regards,
> Bjorn
>
>> + type: object
>> + $ref: /connector/usb-connector.yaml#
>> + description:
>> + Connector for dual role switch, especially for "eud-usb-c-connector"
>> +
>> unevaluatedProperties: false
>>
>> required:
>> --
>> 2.7.4
>>