From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91923C433FE for ; Tue, 1 Feb 2022 00:05:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230022AbiBAAFW (ORCPT ); Mon, 31 Jan 2022 19:05:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229995AbiBAAFV (ORCPT ); Mon, 31 Jan 2022 19:05:21 -0500 Received: from mail-oi1-x22b.google.com (mail-oi1-x22b.google.com [IPv6:2607:f8b0:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF919C06173D for ; Mon, 31 Jan 2022 16:05:21 -0800 (PST) Received: by mail-oi1-x22b.google.com with SMTP id r27so7877783oiw.4 for ; Mon, 31 Jan 2022 16:05:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=QCKQVmWjPU4am1IB1HRTAad0UyZsM4M4bXE/0UUx4OM=; b=ZOsDyVe4kvHNWs+NjElecOefo43rUIcSYceYGyffNEVqkgimTqiLvUy/3P3Yr8oucy 8s462v5f8sZJOkzaHiF5SI/cyQH9j45zVcu+BmeIErRPoKC86N8jBGrm2mG9E6vuYdtP bcIBwtvUTs8xR3fj5dsQtlnzjHwV13y/5uRzans16PSihGQfZwbnvg5+8V/kVDONYm9S rnMhoPeB3Ki2rqeYvmXkwYyRn9xETNkEmA9g4CEBjCPzJqiRIjgttmRmJ8uziIjnbbli nIfo8B80kaWuCpQP0D2ruzkQ4euxJX5cgkd2py3KqJzXBdryz05iIYLcJu0C+GRYw/bg JqQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QCKQVmWjPU4am1IB1HRTAad0UyZsM4M4bXE/0UUx4OM=; b=6hT3QuzLxbtnqyUS/l1r+HQWyT6QwseN/7Gcp7kQFxbOnZaOc9maJ9B5ynLEiPcOlC hVoHt9Sbe9N76HwaFXXikEcVhrk+Ve/sJaY4TLZI13Jaw52ZDSvnC8RKSVdkLq9XPSKq 99tRWsrQjCzf6pCwyvEyuwMAtBHho7x464S3icRV4emZZ/4RfN5t7s+QX5boq1jTvxTO PD89J/x9quZNnuCOoggmqMAdGPDh6ldBvZFIkif6XiHa9OoG2PNehvSR2gaDaWUJ29uT mx3igfE6o7UVE7wgVX5hT1/u2Sx9GOPfpnwcgFJiuWl1qKc1+4A6KfrvhW6/WiYjUYad ulYg== X-Gm-Message-State: AOAM5325Vrl7If2ynlXg9XqVh2aQda1FhH32tmBUbOMhnwZtI8kjnGBn iDsALDDP77s8Ld8Q4N3kFTCxZQ== X-Google-Smtp-Source: ABdhPJzDPBkWMgsXGrWZrHMyZ9FYC3vx4V73mxgp7I0v3jdShKDLw/XSDUwTYo9OPTqIHeFAfH185w== X-Received: by 2002:a05:6808:354:: with SMTP id j20mr14958946oie.130.1643673920773; Mon, 31 Jan 2022 16:05:20 -0800 (PST) Received: from builder.lan ([2600:1700:a0:3dc8:3697:f6ff:fe85:aac9]) by smtp.gmail.com with ESMTPSA id d23sm8656828ote.35.2022.01.31.16.05.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jan 2022 16:05:20 -0800 (PST) Date: Mon, 31 Jan 2022 18:05:18 -0600 From: Bjorn Andersson To: Bhupesh Sharma Cc: linux-arm-msm@vger.kernel.org, bhupesh.linux@gmail.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, agross@kernel.org, sboyd@kernel.org, tdas@codeaurora.org, mturquette@baylibre.com, linux-clk@vger.kernel.org, davem@davemloft.net, netdev@vger.kernel.org Subject: Re: [PATCH 8/8] clk: qcom: gcc-sm8150: Use PWRSTS_ON (only) as a workaround for emac gdsc Message-ID: References: <20220126221725.710167-1-bhupesh.sharma@linaro.org> <20220126221725.710167-9-bhupesh.sharma@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220126221725.710167-9-bhupesh.sharma@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed 26 Jan 16:17 CST 2022, Bhupesh Sharma wrote: > EMAC GDSC currently has issues (seen on SA8155p-ADP) when its > turn'ed ON, once its already in OFF state. So, use PWRSTS_ON > state (only) as a workaround for now. > > Cc: Bjorn Andersson > Cc: Stephen Boyd > Signed-off-by: Bhupesh Sharma > --- > drivers/clk/qcom/gcc-sm8150.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/qcom/gcc-sm8150.c b/drivers/clk/qcom/gcc-sm8150.c > index 2e71afed81fd..fd7e931d3c09 100644 > --- a/drivers/clk/qcom/gcc-sm8150.c > +++ b/drivers/clk/qcom/gcc-sm8150.c > @@ -3449,12 +3449,16 @@ static struct clk_branch gcc_video_xo_clk = { > }, > }; > > +/* To Do: EMAC GDSC currently has issues when its turn'ed ON, once > + * its already in OFF state. So use PWRSTS_ON state (only) as a > + * workaround for now. So you're not able to turn on the GDSC after turning it off? > + */ > static struct gdsc emac_gdsc = { > .gdscr = 0x6004, > .pd = { > .name = "emac_gdsc", > }, > - .pwrsts = PWRSTS_OFF_ON, > + .pwrsts = PWRSTS_ON, Doesn't this tell the gdsc driver that the only state supported is "on" and hence prohibit you from turning it on in the first place? > .flags = POLL_CFG_GDSCR, You could add ALWAYS_ON to .flags, but we need a better description of the actual problem that you're working around. Regards, Bjorn > }; > > -- > 2.34.1 >