From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 624F6C433EF for ; Fri, 11 Feb 2022 00:08:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244327AbiBKAIo (ORCPT ); Thu, 10 Feb 2022 19:08:44 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:42868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239052AbiBKAIm (ORCPT ); Thu, 10 Feb 2022 19:08:42 -0500 Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9EC6D92 for ; Thu, 10 Feb 2022 16:08:42 -0800 (PST) Received: by mail-ot1-x32a.google.com with SMTP id v6-20020a05683024a600b005ac1754342fso1276878ots.5 for ; Thu, 10 Feb 2022 16:08:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=fcC0SEpVltFRTxoXkp53F9HT6U0x1VaT4hIpMkDokFA=; b=ugzulgstXhccLImdFMnJdEshlBhA4kJzeZIOEEsVkSKwCmvbAEVmq9bssZqIMdw/7t bTWC6ml41kJn1oCAn6eBY97CZ0QuM5fnjIPwluI94Hx65W+4UaM6WIigKUTtyuNkxqQK g5nmVhkg0RZTXJXFPstX5Z4veqfI3PCJYQDOeLaac3BmdHdimTQbZNkGDx0+X+WtkTjo Ez5wHKFG+FgMekmSFNCcYi9uFr6rfJCiD+RY86Fh/qrPO3rFLBVU8M1TLPpJmH765buY UdBIZeLbWu4RdJo4dxTbFyRTQmlPIOiIIFZ71VobbhcBb8MJQ3JRsww/J/IDZLppRQ71 c6tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fcC0SEpVltFRTxoXkp53F9HT6U0x1VaT4hIpMkDokFA=; b=4M7us+6SAbN+9OytSLjeBDpLKuXtAApv0TIXLmwR3+cTNQu2IQxZ1cwRpV+AArxw9U MTXaH/yyx3YLCi8gdnZPKR0ofa2ouvCnLAonC2datUn3fiBM3HwbhybAmxcsguSuz4E+ cVSyv0UMC912CLEjaJC3okZoUFirgJwkeYNb4qnCQIiWZX3046hY5Lt43WlKVTpFOnIj XX6GsDkUoQXbURmCwSSHdATrfXzQyiSzlp4vyP1AMisUqh2EPgj5XMkxMxWekQfxXvfC 9/Z3OKiP+WaEEyVYGYQD0Qq6WYD2cjTTn/zEccnJGxbxaZnhvH/q2Cz9RmzjCCbNFzg7 lJVQ== X-Gm-Message-State: AOAM5305Ohv402nOAfNngxO2A3fZHWwkBxAkjFGD+dhLBzXb0avrJwKw GUbDshnF7550KkDwQuRuEg1Uxg== X-Google-Smtp-Source: ABdhPJzHWAm1wwa3ofVjl2ssMnyXrqm4FEc3LXrZHVFMkRd2t4i2qVF3LIT3WQAJ/lod7ClR9v4NOQ== X-Received: by 2002:a05:6830:19f7:: with SMTP id t23mr2021359ott.256.1644538122230; Thu, 10 Feb 2022 16:08:42 -0800 (PST) Received: from builder.lan ([2600:1700:a0:3dc8:3697:f6ff:fe85:aac9]) by smtp.gmail.com with ESMTPSA id bg34sm9133324oob.14.2022.02.10.16.08.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Feb 2022 16:08:41 -0800 (PST) Date: Thu, 10 Feb 2022 18:08:39 -0600 From: Bjorn Andersson To: Sankeerth Billakanti Cc: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, agross@kernel.org, robh+dt@kernel.org, robdclark@gmail.com, seanpaul@chromium.org, swboyd@chromium.org, dianders@chromium.org, krzysztof.kozlowski@canonical.com, thierry.reding@gmail.com, sam@ravnborg.org, airlied@linux.ie, daniel@ffwll.ch, quic_kalyant@quicinc.com, quic_abhinavk@quicinc.com, quic_khsieh@quicinc.com, quic_mkrishn@quicinc.com, quic_vproddut@quicinc.com Subject: Re: [PATCH v4 3/5] arm64: dts: qcom: sc7280: rename edp_out label to mdss_edp_out Message-ID: References: <1644494255-6632-1-git-send-email-quic_sbillaka@quicinc.com> <1644494255-6632-4-git-send-email-quic_sbillaka@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1644494255-6632-4-git-send-email-quic_sbillaka@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu 10 Feb 05:57 CST 2022, Sankeerth Billakanti wrote: > Rename the edp_out label in the sc7280 platform to mdss_edp_out. Next week, or in the next product, it might not be obvious why we did this change. So please continue this sentence with something like "so that the nodes are grouped together when sorted in the dts". > > Signed-off-by: Sankeerth Billakanti > --- > arch/arm64/boot/dts/qcom/sc7280-crd.dts | 10 +++++----- > arch/arm64/boot/dts/qcom/sc7280.dtsi | 2 +- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd.dts b/arch/arm64/boot/dts/qcom/sc7280-crd.dts > index 6dba5ac..af40e14 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-crd.dts > +++ b/arch/arm64/boot/dts/qcom/sc7280-crd.dts > @@ -69,7 +69,7 @@ > port@0 { > reg = <0>; > edp_panel_in: endpoint { > - remote-endpoint = <&edp_out>; > + remote-endpoint = <&mdss_edp_out>; > }; > }; > }; > @@ -129,10 +129,6 @@ ap_ts_pen_1v8: &i2c13 { > }; > }; > > -&edp_out { You just added this node in patch 2 and now you change it immediately. If you reorder the two patches the history will be cleaner. Thanks, Bjorn > - remote-endpoint = <&edp_panel_in>; > -}; > - > &mdss { > status = "okay"; > }; > @@ -156,6 +152,10 @@ ap_ts_pen_1v8: &i2c13 { > /delete-property/ pinctrl-0; > }; > > +&mdss_edp_out { > + remote-endpoint = <&edp_panel_in>; > +}; > + > &mdss_edp_phy { > status = "okay"; > > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi > index 3572399..eca403a 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > @@ -3066,7 +3066,7 @@ > > port@1 { > reg = <1>; > - edp_out: endpoint { }; > + mdss_edp_out: endpoint { }; > }; > }; > > -- > 2.7.4 >