From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1107AC43217 for ; Tue, 1 Mar 2022 23:23:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233722AbiCAXXs (ORCPT ); Tue, 1 Mar 2022 18:23:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229911AbiCAXXr (ORCPT ); Tue, 1 Mar 2022 18:23:47 -0500 Received: from mail-oi1-x233.google.com (mail-oi1-x233.google.com [IPv6:2607:f8b0:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BB4427CE6 for ; Tue, 1 Mar 2022 15:23:04 -0800 (PST) Received: by mail-oi1-x233.google.com with SMTP id p15so239918oip.3 for ; Tue, 01 Mar 2022 15:23:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=B0gHl0FY6TKEqOe5dLt6k+4Sn54m7FTDQTv9BgJSJmY=; b=w0vaAwCSOgyqV35VqOvdvCY5g5lLUapGsVPxGHCUGkyNVEZZ6/kdXXdorDxIWT537G MUzstVRDZ3xYnf+Y9IFCbWdyvIkckOkma3wtDXYzlDYyytWeVjj9Odjlj5+D9r8fwvj2 HBlTjilOI+nEJdz3FhwuFG3VKC9KGwVOZ7O2hrV6heTO5iRov7z0PDXH3z4BPlRzYKTv 5/jrfCYiWgnu5huDJykK1R+/WVA38iPh2c4glxVQ1n0YucaZOGhzKvcC+t97UFVrBEib t7csV3GYm681yeV9UhUvLQCbzuULjwq6xD1qPDdr/pvZDlEKMFcqLg3bq07rx6Y7Y6Ia G1fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=B0gHl0FY6TKEqOe5dLt6k+4Sn54m7FTDQTv9BgJSJmY=; b=s6FHXN27d8UzfXplTPz/iLa3BFDbD8eO3FQBGOWvDehU+Ctf3xEpwpqCy2iH/zwYWY Oavyx7/cSMq+45zuVEKR0DCSIi6ejqOt25OJvY+c28cmcBL9jaTb7lT+n/8j0gwuNY2S Mry1JrcOmSIfmsPlkZfXH4drWlRG45KXBr3wHL7DDBUSkrmRVX7JUQ+1PHVPDahWMnQj P7v6RxyB4opjisLvsPOGA+5ka98tjPiMGN8iai+gXP/VAWZ+R+fz2VOKxPX8YCQCZu2N J/XV3E3i9crJRBRbEsoMUOTXNOiDvBYcpveSNtENLqkcwdIKvVpkIAt9Sd2zGPhMQTVv VFng== X-Gm-Message-State: AOAM530ZCZ0NhwhaD9utdNszWaHMxj9FidnHx1Kfj0j8VaRbCBUMnEr7 zl70moQzt+T09f0tKg1sz9T3Pg== X-Google-Smtp-Source: ABdhPJxEJ64Gn/cTmYTu3qBhsOi969AzEkmMsQpBT2a/tPl/ZeLLMLvf5SzTIPzDYBU8Q9JQ6K3z1w== X-Received: by 2002:a05:6808:1183:b0:2d4:5eeb:1ca3 with SMTP id j3-20020a056808118300b002d45eeb1ca3mr14925434oil.8.1646176983843; Tue, 01 Mar 2022 15:23:03 -0800 (PST) Received: from ripper ([2600:1700:a0:3dc8:205:1bff:fec0:b9b3]) by smtp.gmail.com with ESMTPSA id 16-20020a9d0490000000b005ad3c83e927sm7091173otm.60.2022.03.01.15.23.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Mar 2022 15:23:03 -0800 (PST) Date: Tue, 1 Mar 2022 15:24:54 -0800 From: Bjorn Andersson To: Pavel Machek Cc: Uwe Kleine-K?nig , Thierry Reding , Lee Jones , Rob Herring , Jonathan Corbet , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-pwm@vger.kernel.org, linux-arm-msm@vger.kernel.org, Luca Weiss , Doug Anderson Subject: Re: [PATCH v13 2/2] leds: Add driver for Qualcomm LPG Message-ID: References: <20220218183116.2261770-1-bjorn.andersson@linaro.org> <20220218183116.2261770-2-bjorn.andersson@linaro.org> <20220224165939.4275x7mzp7qpl2kj@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220224165939.4275x7mzp7qpl2kj@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu 24 Feb 08:59 PST 2022, Uwe Kleine-K?nig wrote: > On Fri, Feb 18, 2022 at 10:31:16AM -0800, Bjorn Andersson wrote: [..] > > diff --git a/Documentation/leds/leds-qcom-lpg.rst b/Documentation/leds/leds-qcom-lpg.rst [..] > > +Simple pattern:: > > + > > + "255 500 0 500" > > + > > + ^ > > + | > > + 255 +----+ +----+ > > + | | | | ... > > + 0 | +----+ +---- > > + +----------------------> > > + 0 5 10 15 time (100ms) > > you're mixing tabs and spaces here, I suggest to use spaces only. Not > sure you want to respin for that. > > (I didn't look into the rest of the driver, but assume it's fine.) > Pavel, would yo like me to fix this up and send out v14 or would you be okay replacing the tab with spaces while applying the patches? Do you see any other blockers for merging this? Thanks, Bjorn