From: Andrew Lunn <andrew@lunn.ch>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Baruch Siach <baruch.siach@siklu.com>,
Robert Marko <robert.marko@sartura.hr>,
Luo Jie <luoj@codeaurora.org>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] net: mdio-ipq4019: add delay after clock enable
Date: Mon, 21 Feb 2022 13:52:55 +0100 [thread overview]
Message-ID: <YhOLJwOB/wkwei4L@lunn.ch> (raw)
In-Reply-To: <01c6b6afb00c02a48fa99542c5b4c6a2c69092b0.1645443957.git.baruch@tkos.co.il>
On Mon, Feb 21, 2022 at 01:45:57PM +0200, Baruch Siach wrote:
> From: Baruch Siach <baruch.siach@siklu.com>
>
> Experimentation shows that PHY detect might fail when the code attempts
> MDIO bus read immediately after clock enable. Add delay to stabilize the
> clock before bus access.
>
> PHY detect failure started to show after commit 7590fc6f80ac ("net:
> mdio: Demote probed message to debug print") that removed coincidental
> delay between clock enable and bus access.
>
> 10ms is meant to match the time it take to send the probed message over
> UART at 115200 bps. This might be a far overshoot.
>
> Fixes: 23a890d493e3 ("net: mdio: Add the reset function for IPQ MDIO driver")
> Signed-off-by: Baruch Siach <baruch.siach@siklu.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2022-02-21 13:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 11:45 [PATCH] net: mdio-ipq4019: add delay after clock enable Baruch Siach
2022-02-21 12:52 ` Andrew Lunn [this message]
2022-02-21 13:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhOLJwOB/wkwei4L@lunn.ch \
--to=andrew@lunn.ch \
--cc=baruch.siach@siklu.com \
--cc=baruch@tkos.co.il \
--cc=bryan.odonoghue@linaro.org \
--cc=hkallweit1@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=luoj@codeaurora.org \
--cc=netdev@vger.kernel.org \
--cc=robert.marko@sartura.hr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox