Re: [PATCH v2 04/18] ARM: dts: qcom: disable smb208 regulators for ipq8064-rb3011

Jonathan McDowell
2022-02-22T18:53:58Z

On Fri, Feb 18, 2022 at 01:29:42AM +0100, Ansuel Smith wrote:
> Mikrotik RB3011 have a special configuration where the regulators are
> not the common smb208 controlled by RPM but they use a TPS563900
> controlled via i2c. Disable the smb208 for this specific device.
>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> ---
> arch/arm/boot/dts/qcom-ipq8064-rb3011.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts b/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts
> index 596d129d4a95..0982b6214fb7 100644
> --- a/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts
> +++ b/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts
> @@ -216,6 +216,10 @@ led@7 {
> };
> };
>
> +&smb208_regulators {
> + status = "disabled";
> +}

Missing ; after the }, but with that:

Reviewed-by: Jonathan McDowell <noodles@earth.li>
Tested-by: Jonathan McDowell <noodles@earth.li>

> +
> &adm_dma {
> status = "okay";
> };
> --
> 2.34.1
>

J.

--
/-\ | Design a system any fool can use,
|@/ Debian GNU/Linux Developer | and only a fool will want to use
\- | it.