Re: [PATCH v2 1/4] drm/msm/dp: Add basic PSR support for eDP

Dmitry Baryshkov
2022-02-22T21:23:09Z

On 22/02/2022 22:25, Doug Anderson wrote:
> Hi,
>
> On Mon, Feb 21, 2022 at 7:12 PM Dmitry Baryshkov
> <dmitry.baryshkov@linaro.org> wrote:
>>
>>> +static int dp_link_psr_status(struct dp_link_private *link)
>>> +{
>>> + u8 status[2];
>>> +
>>> + drm_dp_dpcd_read(link->aux, DP_PSR_ERROR_STATUS, status, 2);
>>> +
>>> + if (status[0] & DP_PSR_LINK_CRC_ERROR)
>>> + DRM_ERROR("PSR LINK CRC ERROR\n");
>>> + else if (status[0] & DP_PSR_RFB_STORAGE_ERROR)
>>> + DRM_ERROR("PSR RFB STORAGE ERROR\n");
>>> + else if (status[0] & DP_PSR_VSC_SDP_UNCORRECTABLE_ERROR)
>>> + DRM_ERROR("PSR VSC SDP UNCORRECTABLE ERROR\n");
>>> + else if (status[1] & DP_PSR_CAPS_CHANGE)
>>> + DRM_INFO("PSR Capability Change\n");
>>
>> DRM_DEBUG_DP
>
> Not sure I'll have time to go back and review the series, but one
> thing that caught my eye as this flashed through my inbox is that I
> think all of these "shouting" are deprecated. It's even officially
> documented now as of commit d2f0a8afc1be ("UPSTREAM: drm/print: Add
> deprecation notes to DRM_...() functions").

Agreed. But not the DRM_INFO too.

--
With best wishes
Dmitry