Re: [REPOST PATCH v4 12/13] drm/msm/dsi: add mode valid callback for dsi_mgr

Abhinav Kumar
2022-02-17T03:17:33Z

On 2/10/2022 2:34 AM, Vinod Koul wrote:
> Add a mode valid callback for dsi_mgr for checking mode being valid in
> case of DSC. For DSC the height and width needs to be multiple of slice,
> so we check that here
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
> ---
> drivers/gpu/drm/msm/dsi/dsi.h | 2 ++
> drivers/gpu/drm/msm/dsi/dsi_host.c | 26 ++++++++++++++++++++++++++
> drivers/gpu/drm/msm/dsi/dsi_manager.c | 12 ++++++++++++
> 3 files changed, 40 insertions(+)
>
> diff --git a/drivers/gpu/drm/msm/dsi/dsi.h b/drivers/gpu/drm/msm/dsi/dsi.h
> index 16cd9b2fce86..580a1e6358bf 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi.h
> +++ b/drivers/gpu/drm/msm/dsi/dsi.h
> @@ -114,6 +114,8 @@ int msm_dsi_host_power_on(struct mipi_dsi_host *host,
> int msm_dsi_host_power_off(struct mipi_dsi_host *host);
> int msm_dsi_host_set_display_mode(struct mipi_dsi_host *host,
> const struct drm_display_mode *mode);
> +enum drm_mode_status msm_dsi_host_check_dsc(struct mipi_dsi_host *host,
> + const struct drm_display_mode *mode);
> struct drm_panel *msm_dsi_host_get_panel(struct mipi_dsi_host *host);
> unsigned long msm_dsi_host_get_mode_flags(struct mipi_dsi_host *host);
> struct drm_bridge *msm_dsi_host_get_bridge(struct mipi_dsi_host *host);
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
> index 7e9913eff724..438c80750682 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
> @@ -2552,6 +2552,32 @@ int msm_dsi_host_set_display_mode(struct mipi_dsi_host *host,
> return 0;
> }
>
> +enum drm_mode_status msm_dsi_host_check_dsc(struct mipi_dsi_host *host,
> + const struct drm_display_mode *mode)
> +{
> + struct msm_dsi_host *msm_host = to_msm_dsi_host(host);
> + struct msm_display_dsc_config *dsc = msm_host->dsc;
> + int pic_width = mode->hdisplay;
> + int pic_height = mode->vdisplay;
> +
> + if (!msm_host->dsc)
> + return MODE_OK;
> +
> + if (pic_width % dsc->drm->slice_width) {
> + pr_err("DSI: pic_width %d has to be multiple of slice %d\n",
> + pic_width, dsc->drm->slice_width);
> + return MODE_H_ILLEGAL;
> + }
> +
> + if (pic_height % dsc->drm->slice_height) {
> + pr_err("DSI: pic_height %d has to be multiple of slice %d\n",
> + pic_height, dsc->drm->slice_height);
> + return MODE_V_ILLEGAL;
> + }
> +
> + return MODE_OK;
> +}
> +
> struct drm_panel *msm_dsi_host_get_panel(struct mipi_dsi_host *host)
> {
> return of_drm_find_panel(to_msm_dsi_host(host)->device_node);
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_manager.c b/drivers/gpu/drm/msm/dsi/dsi_manager.c
> index f19bae475c96..e7f6cc88f7a4 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi_manager.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi_manager.c
> @@ -575,6 +575,17 @@ static void dsi_mgr_bridge_mode_set(struct drm_bridge *bridge,
> msm_dsi_host_set_display_mode(other_dsi->host, adjusted_mode);
> }
>
> +static enum drm_mode_status dsi_mgr_bridge_mode_valid(struct drm_bridge *bridge,
> + const struct drm_display_info *info,
> + const struct drm_display_mode *mode)
> +{
> + int id = dsi_mgr_bridge_get_id(bridge);
> + struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id);
> + struct mipi_dsi_host *host = msm_dsi->host;
> +
> + return msm_dsi_host_check_dsc(host, mode);
> +}
> +
> static const struct drm_connector_funcs dsi_mgr_connector_funcs = {
> .detect = dsi_mgr_connector_detect,
> .fill_modes = drm_helper_probe_single_connector_modes,
> @@ -596,6 +607,7 @@ static const struct drm_bridge_funcs dsi_mgr_bridge_funcs = {
> .disable = dsi_mgr_bridge_disable,
> .post_disable = dsi_mgr_bridge_post_disable,
> .mode_set = dsi_mgr_bridge_mode_set,
> + .mode_valid = dsi_mgr_bridge_mode_valid,
> };
>
> /* initialize connector when we're connected to a drm_panel */