From: Mark Brown <broonie@kernel.org>
To: Satya Priya <quic_c_skakit@quicinc.com>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Lee Jones <lee.jones@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, swboyd@chromium.org,
quic_collinsd@quicinc.com, quic_subbaram@quicinc.com,
quic_jprakash@quicinc.com
Subject: Re: [PATCH V9 4/6] regulator: Add a regulator driver for the PM8008 PMIC
Date: Tue, 5 Apr 2022 15:17:41 +0100 [thread overview]
Message-ID: <YkxPhcgBU3/5zu/P@sirena.org.uk> (raw)
In-Reply-To: <1649166633-25872-5-git-send-email-quic_c_skakit@quicinc.com>
[-- Attachment #1: Type: text/plain, Size: 620 bytes --]
On Tue, Apr 05, 2022 at 07:20:31PM +0530, Satya Priya wrote:
> +#include <linux/regulator/driver.h>
> +#include <linux/regulator/machine.h>
Why does the driver need machine.h? That's usually a bug, though I
didn't spot anywhere where it's used so it's probably just an extra
header.
> + .set_voltage_sel = pm8008_regulator_set_voltage,
> + .get_voltage = pm8008_regulator_get_voltage,
You shouldn't mix and match the selector and non-selector operations,
since the device just takes a voltage you may as well just use the
non-selector version for both.
Otherwise this all looks good, just those two minor points.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-04-05 23:34 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 13:50 [PATCH V9 0/6] Add Qualcomm Technologies, Inc. PM8008 regulator driver Satya Priya
2022-04-05 13:50 ` [PATCH V9 1/6] dt-bindings: mfd: pm8008: Add reset-gpios Satya Priya
2022-04-05 19:04 ` Stephen Boyd
2022-04-13 1:50 ` Rob Herring
2022-04-05 13:50 ` [PATCH V9 2/6] dt-bindings: mfd: pm8008: Add pm8008 regulator bindings Satya Priya
2022-04-05 19:05 ` Stephen Boyd
2022-04-13 1:51 ` Rob Herring
2022-04-05 13:50 ` [PATCH V9 3/6] mfd: pm8008: Add mfd cell struct to register LDOs Satya Priya
2022-04-05 19:08 ` Stephen Boyd
2022-04-06 9:19 ` Satya Priya Kakitapalli (Temp)
2022-04-05 13:50 ` [PATCH V9 4/6] regulator: Add a regulator driver for the PM8008 PMIC Satya Priya
2022-04-05 14:17 ` Mark Brown [this message]
2022-04-06 9:06 ` Satya Priya Kakitapalli (Temp)
2022-04-05 19:09 ` Stephen Boyd
2022-04-06 7:31 ` Mark Brown
2022-04-06 15:23 ` Stephen Boyd
2022-04-06 15:45 ` Mark Brown
2022-04-06 15:51 ` Stephen Boyd
2022-04-06 16:36 ` Mark Brown
2022-04-06 17:21 ` Stephen Boyd
2022-04-06 17:27 ` Mark Brown
2022-04-06 18:16 ` Stephen Boyd
2022-04-07 5:12 ` Satya Priya Kakitapalli (Temp)
2022-04-06 9:38 ` Satya Priya Kakitapalli (Temp)
2022-04-05 19:09 ` Stephen Boyd
2022-04-06 9:26 ` Satya Priya Kakitapalli (Temp)
2022-04-05 13:50 ` [PATCH V9 5/6] arm64: dts: qcom: pm8008: Add base dts file Satya Priya
2022-04-05 19:11 ` Stephen Boyd
2022-04-06 9:27 ` Satya Priya Kakitapalli (Temp)
2022-04-05 13:50 ` [PATCH V9 6/6] arm64: dts: qcom: sc7280: Add pm8008 support for sc7280-idp Satya Priya
2022-04-05 19:13 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkxPhcgBU3/5zu/P@sirena.org.uk \
--to=broonie@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_c_skakit@quicinc.com \
--cc=quic_collinsd@quicinc.com \
--cc=quic_jprakash@quicinc.com \
--cc=quic_subbaram@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox