From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9777C433FE for ; Wed, 20 Apr 2022 05:36:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245452AbiDTFjN (ORCPT ); Wed, 20 Apr 2022 01:39:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244915AbiDTFjM (ORCPT ); Wed, 20 Apr 2022 01:39:12 -0400 Received: from mo4-p02-ob.smtp.rzone.de (mo4-p02-ob.smtp.rzone.de [85.215.255.80]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 762686560; Tue, 19 Apr 2022 22:36:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1650432983; s=strato-dkim-0002; d=gerhold.net; h=In-Reply-To:References:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=JLun0YrEgADl0EiMrgJKZfIPYsBXKlKt85NSwxmMW2o=; b=hHjIdCpF/CVuyZoPsrZw4AgoX/7oihpN76GzP2L8EZTMk97XiKg7erAxYs9WJUmfPk vsGTskJr5jm8D0aF4mpktMDehU/SyGYLjQpLT6yNlltA257Jgf1pSZYtBDkzGmdhc6ES yjVNL6BFPgr02OIqik425WWJOzpI9M11MfBvnqvxYQ4Z0wbvGZNVxrNUeUWpPWU16qyO uGuNLvX+xFEERMbzhOm1MJOwNrkPGQdnms0t+gE69pBWxr3xCt81HfVL1NWx1PVSM8eE DYIYXS6o8YkdCMNLQkqtBVM4RrbE8exNdGON1mZIkDPpZOm/u8QYtz/hK9rs+jb3BQLF nJtQ== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P3gBZUipdd93FF5ZZvYFPugejmSTVR2nRPhVOQ/OcYgojyw4j34+u267FZF9PwpcNKLVrK88/6Y=" X-RZG-CLASS-ID: mo00 Received: from gerhold.net by smtp.strato.de (RZmta 47.42.2 AUTH) with ESMTPSA id u05e50y3K5aMver (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Wed, 20 Apr 2022 07:36:22 +0200 (CEST) Date: Wed, 20 Apr 2022 07:36:21 +0200 From: Stephan Gerhold To: Bryan O'Donoghue Cc: agross@kernel.org, bjorn.andersson@linaro.org, robh+dt@kernel.org, krzk+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, shawn.guo@linaro.org, jun.nie@linaro.org, benl@squareup.com, jwillcox@squareup.com, jgates@squareup.com, mchen@squareup.com, zac@squareup.com Subject: Re: [PATCH v1 4/4] arm64: dts: Add msm8939 Sony Xperia M4 Aqua Message-ID: References: <20220419010903.3109514-1-bryan.odonoghue@linaro.org> <20220419010903.3109514-5-bryan.odonoghue@linaro.org> <552547c1-36c3-8d7e-0fd5-1b22fd184b4b@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <552547c1-36c3-8d7e-0fd5-1b22fd184b4b@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, Apr 19, 2022 at 11:03:30PM +0100, Bryan O'Donoghue wrote: > On 19/04/2022 20:27, Stephan Gerhold wrote: > > tulip seems to have qcom,usbid-gpio = <&msm_gpio 110 0>; downstream. > > Have you tried setting it up using linux,extcon-usb-gpio? > > See e.g. msm8916-longcheer-l8910, it has a similar setup (it also uses > > smb1360 for charging actually). > > > > The advantage is that you don't need the manual role switching using > > "usb-role-switch", USB OTG adapters should be detected automatically. > > My understanding is "no new extcon" - certainly as driver implementations I > assume that also extends to dts.. > It's probably tricky to combine the USB-C stuff with extcon since that needs driver changes. But for good old micro USB stuff extcon is (perhaps sadly) the standard and it's exactly what the USB and USB PHY driver expects. So in my opinion you might as well make use of it. :)