From: Stephan Gerhold <stephan@gerhold.net>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
agross@kernel.org, robh+dt@kernel.org, krzk+dt@kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
shawn.guo@linaro.org, jun.nie@linaro.org, benl@squareup.com,
jwillcox@squareup.com, jgates@squareup.com, mchen@squareup.com,
zac@squareup.com, Leo Yan <leo.yan@linaro.org>
Subject: Re: [PATCH v1 2/4] arm64: dts: Add msm8939 SoC
Date: Wed, 20 Apr 2022 07:34:12 +0200 [thread overview]
Message-ID: <Yl+bVNptu4hopExO@gerhold.net> (raw)
In-Reply-To: <Yl8lf6/eQ1hrcIKd@builder.lan>
On Tue, Apr 19, 2022 at 04:11:27PM -0500, Bjorn Andersson wrote:
> On Mon 18 Apr 20:09 CDT 2022, Bryan O'Donoghue wrote:
> [..]
> > +
> > +#include "msm8916-pins.dtsi"
>
> I thought we got rid of the separate *-pins.dtsi file. I'm also worried
> about sharing this between 8916 and 8939. Can you please inline this in
> line with one of the newer platform.
Why is this worrying? AFAIK MSM8939 is pin-compatible with MSM8916, it
uses the same pinctrl driver and compatible = "qcom,msm8916-pinctrl".
You definitely need the same definitions when setting up device trees
for 8939 devices.
In fact most of the MSM8939 device trees that I have seen in the
postmarketOS kernel fork look pretty much like the existing MSM8916
ones, just with the msm8916.dtsi include replaced with msm8939.dtsi.
And I think that's a good thing for consistency and maintenance. :)
I guess if we don't want separate -pins.dtsi anymore this just brings up
the question again if parts of msm8916.dtsi and msm8939.dtsi should be
shared in a .dtsi...
next prev parent reply other threads:[~2022-04-20 5:34 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 1:08 [PATCH v1 0/4] Add MSM8939 SoC support with two devices Bryan O'Donoghue
2022-04-19 1:09 ` [PATCH v1 1/4] dt-bindings: arm: qcom: Document MSM8939 SoC binding Bryan O'Donoghue
2022-04-19 7:13 ` Krzysztof Kozlowski
2022-04-19 12:12 ` Rob Herring
2022-04-19 1:09 ` [PATCH v1 2/4] arm64: dts: Add msm8939 SoC Bryan O'Donoghue
2022-04-19 7:33 ` Krzysztof Kozlowski
2022-04-19 8:30 ` Bryan O'Donoghue
2022-04-19 8:44 ` Krzysztof Kozlowski
2022-04-20 9:31 ` Jun Nie
2022-04-20 9:38 ` Krzysztof Kozlowski
2022-04-20 9:57 ` Jun Nie
2022-04-20 10:00 ` Jun Nie
2022-04-20 10:10 ` Krzysztof Kozlowski
2022-04-20 10:09 ` Krzysztof Kozlowski
2022-04-19 18:31 ` Stephan Gerhold
2022-04-20 10:12 ` Jun Nie
2022-04-19 21:11 ` Bjorn Andersson
2022-04-20 5:34 ` Stephan Gerhold [this message]
[not found] ` <bc6ce23672c52b1f2593fcac720edf9ca9e9fdaa.camel@mailoo.org>
2022-04-19 22:01 ` Bryan O'Donoghue
2022-05-26 13:32 ` Bryan O'Donoghue
2022-04-19 1:09 ` [PATCH v1 3/4] arm64: dts: Add aqp8039-t2 board Bryan O'Donoghue
2022-04-19 7:35 ` Krzysztof Kozlowski
2022-04-19 19:20 ` Stephan Gerhold
2022-04-19 21:43 ` Bryan O'Donoghue
2022-04-19 21:39 ` Bjorn Andersson
2022-04-19 21:52 ` Bryan O'Donoghue
2022-04-19 1:09 ` [PATCH v1 4/4] arm64: dts: Add msm8939 Sony Xperia M4 Aqua Bryan O'Donoghue
2022-04-19 19:27 ` Stephan Gerhold
2022-04-19 22:03 ` Bryan O'Donoghue
2022-04-20 5:36 ` Stephan Gerhold
2022-05-26 22:03 ` Dmitry Baryshkov
2022-04-19 21:51 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yl+bVNptu4hopExO@gerhold.net \
--to=stephan@gerhold.net \
--cc=agross@kernel.org \
--cc=benl@squareup.com \
--cc=bjorn.andersson@linaro.org \
--cc=bryan.odonoghue@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jgates@squareup.com \
--cc=jun.nie@linaro.org \
--cc=jwillcox@squareup.com \
--cc=krzk+dt@kernel.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=mchen@squareup.com \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=zac@squareup.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox