From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C086C433FE for ; Thu, 28 Apr 2022 16:29:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350051AbiD1QdK (ORCPT ); Thu, 28 Apr 2022 12:33:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349580AbiD1QdJ (ORCPT ); Thu, 28 Apr 2022 12:33:09 -0400 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1790ADD66 for ; Thu, 28 Apr 2022 09:29:54 -0700 (PDT) Received: by mail-pj1-x102c.google.com with SMTP id r9so4771453pjo.5 for ; Thu, 28 Apr 2022 09:29:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=CJmhCZrPiMZavdtPtKt7xyW0gxGaYnzd2PM8IzF7MPg=; b=X3HOsh0tZ+eIfltRMrj9e9yV1GkIordsNCmL08mhL3XR4tDS9U4su2Unea9wjKYi/Y BQOzUD1l7qKivIM7Dr81NYl5HTdG7pEOZJLR75jjB/iLVwQU1Edhr+GpDcOCK71E0/uq eqa5bMvVaseHbsWBKg3lSd7oLe//wkHjNbu3E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CJmhCZrPiMZavdtPtKt7xyW0gxGaYnzd2PM8IzF7MPg=; b=S6bPAFlHeShMU/ISl4bkxuHit1s5FP4kyCEGyqtKwFi9CpeICqs1/XzeKFp58HeJeC kpmeaXpyFyWkETl3X2BM2hcZoje8QvNEVAuuQol5/UEvRekBW6J1q3kHd23ZFpiZkvbn 7i6E+3IE4XFPBRuQydts1G3h/sOLbgNyTX4Y+yLqZi9J7Z59Ifi75GFQ2po3wrxZGRBf y/JfRnQTS0EgnibCIDxNtyOJ7RxRe3f65VuDVfSxTUDAKJcO2BPXza2X0gm248K3jlQ4 fEAZsqGMO3uv3CCcWvEeR4x9RnPqN/MKMsyHrbPK/8iUIMe2SOj/6z7vy7huuXd8t8K+ jtXw== X-Gm-Message-State: AOAM530fE5ORQO0wxv8jJs3esmCThqOctB+gPcFBj77Wvc1t0zWJfBxH qLANJfUwX3Uqa7iUGGtJLufC0g== X-Google-Smtp-Source: ABdhPJwngjzLNM1RYjk6ZGoF5WQowA+1yjqvnIx2iJZajpuIzkDmj5PjmxpfmftbRbpe1+CWrrnwag== X-Received: by 2002:a17:902:cf05:b0:156:9d:ca01 with SMTP id i5-20020a170902cf0500b00156009dca01mr33856986plg.111.1651163394343; Thu, 28 Apr 2022 09:29:54 -0700 (PDT) Received: from localhost ([2620:15c:202:201:7a56:fc44:2682:8a2e]) by smtp.gmail.com with UTF8SMTPSA id o1-20020a629a01000000b0050d92e7d0c8sm293905pfe.180.2022.04.28.09.29.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Apr 2022 09:29:53 -0700 (PDT) Date: Thu, 28 Apr 2022 09:29:52 -0700 From: Matthias Kaehlcke To: Doug Anderson Cc: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , linux-arm-msm , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , Stephen Boyd Subject: Re: [PATCH v22 2/2] arm64: dts: qcom: sc7280-herobrine: Add nodes for onboard USB hub Message-ID: References: <20220426170306.v22.1.I7a1a6448d50bdd38e6082204a9818c59cc7a9bfd@changeid> <20220426170306.v22.2.I18481b296484eec47bdc292a31fa46fa8c655ca9@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, Apr 27, 2022 at 02:06:00PM -0700, Doug Anderson wrote: > Hi, > > On Tue, Apr 26, 2022 at 5:03 PM Matthias Kaehlcke wrote: > > > > Add nodes for the onboard USB hub on herobrine devices. Remove the > > 'always-on' property from the hub regulator, since the regulator > > is now managed by the onboard_usb_hub driver. > > > > Signed-off-by: Matthias Kaehlcke > > --- > > > > Changes in v22: > > - patch added to the series > > > > .../arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 21 ++++++++++++++++++- > > 1 file changed, 20 insertions(+), 1 deletion(-) > > Just like on patch #1, I presume it will be moderately annoying if > this lands in the Qualcomm branch before the driver lands in mainline? > I guess very few people have herobrine hardware, so maybe not that big > of a deal... For herobrine it's probably not a big deal, hardware isn't publicly available and those who have run it with a CrOS based kernel most of the time. But yeah, it would be somewhat annoying if USB is broken when you test something with an upstream kernel. > In any case, I'm happy with: > > Reviewed-by: Douglas Anderson Thanks!