From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B455C433EF for ; Wed, 4 May 2022 13:04:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237497AbiEDNI3 (ORCPT ); Wed, 4 May 2022 09:08:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239632AbiEDNI1 (ORCPT ); Wed, 4 May 2022 09:08:27 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57D6D3DA6C for ; Wed, 4 May 2022 06:04:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B9CFB618B6 for ; Wed, 4 May 2022 13:04:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 437A0C385A4; Wed, 4 May 2022 13:04:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651669491; bh=zHWcpt3bK0TDTAN2FqBM6HMQFW9CX5zg/jNylvcfIaA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FsdkLXYTzrKjJsxb6Vs5S1KirEgfixOt3aUhgUTJPttgvk84wO6C8pol8JoyxCmXA Y4ahHI4GNvXe5SMR4RN7uJfkn1x4Fm4hD1kAw929vpPljMTXc2f9BiDe+0s6Hfjhq3 o0rskrEMhOW5teED8d8vadEBcyEOInauvQl8Rpr1urZDA8mAmnFaA4esTxE8kkdeyl GtshsPlmWckS2evRqHw++8QKMJ2fUOcZaH+q+jtsH4Rw/xsjfbT9rgmkQNgihse2oi bxTdeVeN47eOFPhlJmoACu3Yk0PvYh6MXipHWBrm603kOb8COM/rcrd0JGcueKW18G ahHYo63ZDXITQ== Date: Wed, 4 May 2022 18:34:46 +0530 From: Vinod Koul To: Dmitry Baryshkov Cc: Thierry Reding , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Rob Clark , Abhinav Kumar , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 0/3] drm: move dsc data pointer from drm_panel to mipi_dsi_device Message-ID: References: <20220501151220.3999164-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220501151220.3999164-1-dmitry.baryshkov@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 01-05-22, 18:12, Dmitry Baryshkov wrote: > To properly support DSC the sink driver (panel) has to pass DSC pps data > to the source (DSI host). The commit 0f40ba48de3b ("drm/msm/dsi: Pass > DSC params to drm_panel") added a pointer to the DSC data to the struct > drm_panel. However this is not the ideal solution. > > First, this leaves DSC-supporting DSI sink bridges (like ANX7625 which > support DSC decoding on the MIPI DSI inputs). > > Second, this does not play well with the panel_bridge. Drivers depending > solely on the bridge chains will still have to lookup panel and fetch > data from it. > > Last, but not least, the DSC data is not relevant for the wide variety > of panels including DPI and LVDS panels. > > To solve all these problems, move struct drm_dsc_config pointer from > struct drm_panel to struct mipi_host_device. This way MIPI DSI host > driver receives DSC data during attach callback without additional > lookups. Reviewed-by: Vinod Koul I tested this on my pixel3 and had to change how panel driver handles this, with that it worked just fine Tested-by: Vinod Koul -- ~Vinod