From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF5C8C4332F for ; Wed, 11 May 2022 03:54:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231158AbiEKDyQ (ORCPT ); Tue, 10 May 2022 23:54:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234629AbiEKDyM (ORCPT ); Tue, 10 May 2022 23:54:12 -0400 Received: from mail-oa1-x35.google.com (mail-oa1-x35.google.com [IPv6:2001:4860:4864:20::35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CAB4E4C7A1 for ; Tue, 10 May 2022 20:54:10 -0700 (PDT) Received: by mail-oa1-x35.google.com with SMTP id 586e51a60fabf-e5e433d66dso1405512fac.5 for ; Tue, 10 May 2022 20:54:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0WrSL/b+MR9+m4rRbjGXRX60B+r7zy7wkt64zUH48oY=; b=rDNhyYBHwTL4zR2u6Rh91X182mgiFM7lrZSGXKOmY04hNhVAPm4Dgx0gU5cVJ2vGDC VVK0s4uScAZKYRBD/jNDbgkWWuBV5j+CeByod0LNmbTJY6H1BdD52pzirbR50niNQOWs 4UcMfF4B2g4Ic9rYOGzl0LOSN1aaLtLb/R9U55fs4o/J0pMUPrqbzTdJSVKL4Fh78wGH oqA+4Tao/oGIRZvarBpyi6x4Gmuur5E3YRVUVPWpq48UoXcyFBPUo67hsWk85HdW1Iyu UKVBVAQsXQiIpeynG/0M9jNsljMLvTSFcolAfzNWxtFedgaFi3D/S+XxgXcjaVIGS2sh xkqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0WrSL/b+MR9+m4rRbjGXRX60B+r7zy7wkt64zUH48oY=; b=wg+CGuj/xb7JJDX+VurvQfWDYM99xfTrTZSgfEoWT8HZrmh/ik3WBxNzqNkbnlTKi7 UEWPVOx9HBQh9I6aVGS1MY32q58Io3A9PEN6kR9xRMpr3mfX+q2GBgp84d6fasa8zeTu IyfOP/ED0dkp5RHrAeO1bIv+jMDPVUeEJMw7vd7/T/aYpt2BsXIMhP0sDgJXqkJUAzBP d05m2PutDAZjG0N7yz7AHGZgrZOsGPeteOqho70nbZFcHWi11d8zUKY72swzemuB5xfc yCOoYK6ZtLQTIC97UYWMwxh9hjIiG46AhNr6E/G7NkEWpY8zqitra6VssNuB/vogPlzn l7nA== X-Gm-Message-State: AOAM530YQMaAZHlZQsZmWrjtUNE3Cu23S5Llrt+dNkwPCiznYiM93EbB XBN00sqzmi0TpNEqK8OsL7bayA== X-Google-Smtp-Source: ABdhPJyoFDZ6uvhFkWPUEbCyNMWvl/HBFzH2dTTIdFcRPaK+Uq/uWTzwMP5AeRGfoz4hWcMS4Eo26w== X-Received: by 2002:a05:6870:818a:b0:f1:1223:3afd with SMTP id k10-20020a056870818a00b000f112233afdmr497822oae.271.1652241250132; Tue, 10 May 2022 20:54:10 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id l6-20020a056830154600b0060603221269sm397354otp.57.2022.05.10.20.54.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 May 2022 20:54:09 -0700 (PDT) Date: Tue, 10 May 2022 22:54:07 -0500 From: Bjorn Andersson To: Marijn Suijten Cc: phone-devel@vger.kernel.org, Pavel Machek , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , linux-arm-msm@vger.kernel.org, linux-leds@vger.kernel.org, Rob Herring , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Matthias Kaehlcke , Stephen Boyd , Satya Priya Subject: Re: [PATCH 2/4] leds: qcom-lpg: Add PM660L configuration and compatible Message-ID: References: <20220507221123.2201668-1-marijn.suijten@somainline.org> <20220507221123.2201668-2-marijn.suijten@somainline.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220507221123.2201668-2-marijn.suijten@somainline.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Sat 07 May 17:11 CDT 2022, Marijn Suijten wrote: > Inherit PM660L PMIC LPG/triled block configuration from downstream > drivers and DT sources, consisting of a triled block with automatic > trickle charge control and source selection, three colored led channels > belonging to the synchronized triled block and one loose PWM channel. > > Signed-off-by: Marijn Suijten > --- > drivers/leds/rgb/leds-qcom-lpg.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/drivers/leds/rgb/leds-qcom-lpg.c b/drivers/leds/rgb/leds-qcom-lpg.c > index cfa3362b2457..30c12ac8eed4 100644 > --- a/drivers/leds/rgb/leds-qcom-lpg.c > +++ b/drivers/leds/rgb/leds-qcom-lpg.c > @@ -1271,6 +1271,23 @@ static int lpg_remove(struct platform_device *pdev) > return 0; > } > > +static const struct lpg_data pm660l_lpg_data = { > + .lut_base = 0xb000, > + .lut_size = 0x100, The documentation tells me that you have 49 entries of LUT on the PM660L. > + > + .triled_base = 0xd000, > + .triled_has_atc_ctl = true, > + .triled_has_src_sel = true, > + > + .num_channels = 4, > + .channels = (struct lpg_channel_data[]) { This can be const Regards, Bjorn > + { .base = 0xb100, .triled_mask = BIT(5) }, > + { .base = 0xb200, .triled_mask = BIT(6) }, > + { .base = 0xb300, .triled_mask = BIT(7) }, > + { .base = 0xb400 }, > + }, > +}; > + > static const struct lpg_data pm8916_pwm_data = { > .num_channels = 1, > .channels = (const struct lpg_channel_data[]) { > @@ -1391,6 +1408,7 @@ static const struct lpg_data pm8350c_pwm_data = { > }; > > static const struct of_device_id lpg_of_table[] = { > + { .compatible = "qcom,pm660l-lpg", .data = &pm660l_lpg_data }, > { .compatible = "qcom,pm8150b-lpg", .data = &pm8150b_lpg_data }, > { .compatible = "qcom,pm8150l-lpg", .data = &pm8150l_lpg_data }, > { .compatible = "qcom,pm8350c-pwm", .data = &pm8350c_pwm_data }, > -- > 2.36.0 >