Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Robert Marko <robimarko@gmail.com>
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
	lgirdwood@gmail.com, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] regulator: qcom_smd: correct MP5496 ranges
Date: Tue, 7 Jun 2022 20:21:22 +0100	[thread overview]
Message-ID: <Yp+lMm66+imh1wvk@sirena.org.uk> (raw)
In-Reply-To: <20220604193300.125758-2-robimarko@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 415 bytes --]

On Sat, Jun 04, 2022 at 09:33:00PM +0200, Robert Marko wrote:
> Currently set MP5496 Buck and LDO ranges dont match its datasheet[1].
> According to the datasheet:
> Buck range is 0.6-2.1875V with a 12.5mV step
> LDO range is 0.8-3.975V with a 25mV step.

Doesn't make much difference here but in general fixes like this should
come before new features in a series so they can be applied without
dependency issues.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2022-06-07 22:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-04 19:32 [PATCH 1/2] regulator: qcom_smd: add get_voltage to MP5496 Robert Marko
2022-06-04 19:33 ` [PATCH 2/2] regulator: qcom_smd: correct MP5496 ranges Robert Marko
2022-06-07 19:21   ` Mark Brown [this message]
2022-06-07 20:49     ` Robert Marko
2022-06-08 10:49 ` [PATCH 1/2] regulator: qcom_smd: add get_voltage to MP5496 Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yp+lMm66+imh1wvk@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robimarko@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox