Re: [PATCH v3 3/5] arm64: dts: qcom: sm8250: camss: Define ports address/size cells

[Bjorn Andersson <bjorn.andersson@linaro.org>]

On Mon 06 Jun 08:20 CDT 2022, Bryan O'Donoghue wrote:

> The ports {} address and size cells definition is the same for every
> derived 8250 board so, we should define it in the core sm8250.dtsi.
> 
> Suggested-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/sm8250.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> index 2bc11cad3a44..aa9a13364865 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> @@ -3395,6 +3395,11 @@ camss: camss@ac6a000 {
>  					     "cam_hf_0_mnoc",
>  					     "cam_sf_0_mnoc",
>  					     "cam_sf_icp_mnoc";
> +
> +			ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;

Adding these without subnodes that make use of them will cause
dtbs_check to complain.

So although it would save a little bit of duplication, let's add them
when/where it's needed.

Regards,
Bjorn

> +			};
>  		};
>  
>  		camcc: clock-controller@ad00000 {
> -- 
> 2.36.1
>