From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 807E5C43334 for ; Fri, 1 Jul 2022 04:03:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234731AbiGAEDC (ORCPT ); Fri, 1 Jul 2022 00:03:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234738AbiGAECh (ORCPT ); Fri, 1 Jul 2022 00:02:37 -0400 Received: from mail-ot1-x334.google.com (mail-ot1-x334.google.com [IPv6:2607:f8b0:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AAB4170AEB for ; Thu, 30 Jun 2022 21:00:15 -0700 (PDT) Received: by mail-ot1-x334.google.com with SMTP id e14-20020a9d018e000000b00618ca3183a0so323668ote.13 for ; Thu, 30 Jun 2022 21:00:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=UIQbOmI3pL7SkABqDJH+080MonEhwBz+pt3xl6BVtfY=; b=VaIR2IHSPRPJ4kuxXmfzhrJ0wSULAztD2o7AVZAHEJ8Te02eO8QDQCGlIdZ5mYkpX6 ylFuZoHqHx2+xfG4+1DRCC40gKFT8T8hvE+XDWCe7pWtdBWQ1lrrvtolJyrdefVkcN6F h9B9SR6lGywh1BjymSnUXOU83OnudKCp+hQGliBhjX+JaQkkzxpSsMT2Bgshljx+jPBS eO6ReqMUrYnvNXKzIdcRBmwzzIRdo9yQ+ETzjlew7HKujhn5mSfRy2+DZzNzFauNQMoB DpL3S+EZY0ZuLIUMNVCNc1ZEBxiA95yfKfFc5fuLxpCMw/8XaoiNOGaeUUBnMqTE69fY ft/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=UIQbOmI3pL7SkABqDJH+080MonEhwBz+pt3xl6BVtfY=; b=ggV1wyGNs7WIBbeoVFzol86Ua/QhFNGe4rJHduCUtKlSuGoEszqF7DroB7KA8WJhMf fWfA7NKSoqjMfvPgjBYatcd2QQC/EpT0hm/mTq8ZGyG9DL4/5Sqg2b06JUUX6cxLnwiv mwiS/s4yMPpRfvGtIxN3l5xgvxgdgpER+BPQDZS95gXu9FmU2REsI6cSgdRZPsPPwoGE VskP7GlExtBRi1mxvqytrWdPalt5jlETbMNa7oRnZscTrpXZ/aN5eMfr5vjuKaSdtNdv DbSgriQTtNKP/Ca9oIdRD1znCuOUU3YXun/hiN0XVphwQEGETDLMoktojFj9MA2OUBmQ wy2Q== X-Gm-Message-State: AJIora8w6c+7dOYuiOCtviAKdv2Mo0JP9Q3+XMcgEk23vBL01g+g7t/g m3mYR57SGVQd/tmQJZvhyJqM/w== X-Google-Smtp-Source: AGRyM1uXeVOAg5ZEY1ZkjTbui+MlAXJH0K22EzbbOpufiKUlHPpw/tLNbnYPCH5I6VHR2KWyRNHqAA== X-Received: by 2002:a05:6830:12cb:b0:616:b36b:e50b with SMTP id a11-20020a05683012cb00b00616b36be50bmr5751122otq.1.1656648014778; Thu, 30 Jun 2022 21:00:14 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id s4-20020a056870ea8400b000f1bc45ba21sm15063247oap.14.2022.06.30.21.00.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jun 2022 21:00:14 -0700 (PDT) Date: Thu, 30 Jun 2022 23:00:11 -0500 From: Bjorn Andersson To: Stephen Boyd Cc: Michael Turquette , Stephen Boyd , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, patches@lists.linux.dev, linux-arm-msm@vger.kernel.org, Taniya Das , Mike Tipton Subject: Re: [PATCH/RFC] clk: qcom: rpmh: Block system suspend if XO is enabled Message-ID: References: <20220628201340.3981860-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220628201340.3981860-1-swboyd@chromium.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue 28 Jun 15:13 CDT 2022, Stephen Boyd wrote: > Tracking down what RPMh resource is blocking XO shutdown in suspend is > hard. Largely because we need external debug tools to dump the RPMh > internal state to figure out what resource is enabled. Instead of doing > that, let's just block system wide suspend in the kernel if the RPMh XO > resource is enabled by something in the kernel. This will help us narrow > down XO shutdown failures to the XO clk, and not something else like an > interconnect or regulator RPMh resource. > > I'm sending this as an RFC because it breaks suspend for me on Trogdor > boards. I found out that the XO resource is always enabled on these > devices because the audio driver leaves an audio clk always on. This > means that the XO resource must not be used to determine if XO shutdown > is achievable, or we're leaving power savings on the table. > > Cc: Taniya Das > Cc: Mike Tipton > Signed-off-by: Stephen Boyd Reviewed-by: Bjorn Andersson > --- > > Please don't apply. It will break suspend on Trogdor boards. > This seems like a useful debug feature for people outside of Qualcomm, so I assume you're saying that we shouldn't merge it until someone has fixed the audio driver? Or did you post it just as a debug tool? Regards, Bjorn > drivers/clk/qcom/clk-rpmh.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c > index aed907982344..ba0e0e4b9cf2 100644 > --- a/drivers/clk/qcom/clk-rpmh.c > +++ b/drivers/clk/qcom/clk-rpmh.c > @@ -70,6 +70,14 @@ struct clk_rpmh_desc { > > static DEFINE_MUTEX(rpmh_clk_lock); > > +/* XO shutdown will fail if XO is enabled across suspend */ > +static int clk_rpmh_suspend(struct device *dev) > +{ > + struct clk_rpmh *xo = dev_get_drvdata(dev); > + > + return xo && xo->state ? -EBUSY : 0; > +} > + > #define __DEFINE_CLK_RPMH(_platform, _name, _name_active, _res_name, \ > _res_en_offset, _res_on, _div) \ > static struct clk_rpmh _platform##_##_name_active; \ > @@ -690,6 +698,10 @@ static int clk_rpmh_probe(struct platform_device *pdev) > dev_err(&pdev->dev, "failed to register %s\n", name); > return ret; > } > + > + /* Stash CXO clk for XO shutdown tracking */ > + if (i == RPMH_CXO_CLK) > + platform_set_drvdata(pdev, rpmh_clk); > } > > /* typecast to silence compiler warning */ > @@ -722,9 +734,12 @@ static const struct of_device_id clk_rpmh_match_table[] = { > }; > MODULE_DEVICE_TABLE(of, clk_rpmh_match_table); > > +static SIMPLE_DEV_PM_OPS(clk_rpmh_pm_ops, clk_rpmh_suspend, NULL); > + > static struct platform_driver clk_rpmh_driver = { > .probe = clk_rpmh_probe, > .driver = { > + .pm = pm_ptr(&clk_rpmh_pm_ops), > .name = "clk-rpmh", > .of_match_table = clk_rpmh_match_table, > }, > > base-commit: f2906aa863381afb0015a9eb7fefad885d4e5a56 > -- > https://chromeos.dev >