From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A648CC433EF for ; Thu, 23 Jun 2022 11:51:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231374AbiFWLv5 (ORCPT ); Thu, 23 Jun 2022 07:51:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229826AbiFWLv4 (ORCPT ); Thu, 23 Jun 2022 07:51:56 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9B174D247; Thu, 23 Jun 2022 04:51:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 87943B82260; Thu, 23 Jun 2022 11:51:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49D3CC341C7; Thu, 23 Jun 2022 11:51:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655985112; bh=YxjkbmtWiwKyXSfh9J1LCaGUej6BwFLLjiSLAdMtBEo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gpQy8Lwa6qn8PfIky19HgsNqZNmbA/uJArEGXy+A+f7hTIGSrW8MLkNPzgQUnc/Qd KuksUcv/lV3mrSYfXiPcpoouH+EXWFHqGG3j2XdKmT4bJyGcNbGf9z4FRdga8mD6yu n1T4ZbxaYKJ1SAPINP/e4o40VhII+9LptveuB7SZFQ5JXT/nFG7kgU+astQ3K4cpAQ cpLLoBeKI3rECMZDHTqXFpYzPGOCexhamO9J3QHhDlFf06h9diPNAxf71zD2usQ4PK TgCRjRPSCCBWIsh+CFftan8wWiz3dDLsDHowrL6BUGmFXRqeZOgsO70Mj9/cvtxMkA 91QG7KxUS6Usg== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o4LNA-0007s6-5m; Thu, 23 Jun 2022 13:51:44 +0200 Date: Thu, 23 Jun 2022 13:51:44 +0200 From: Johan Hovold To: Dmitry Baryshkov Cc: Johan Hovold , Vinod Koul , Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] phy: qcom-qmp-pcie: drop obsolete pipe clock type check Message-ID: References: <20220623113314.29761-1-johan+linaro@kernel.org> <20220623113314.29761-2-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, Jun 23, 2022 at 02:44:28PM +0300, Dmitry Baryshkov wrote: > On Thu, 23 Jun 2022 at 14:33, Johan Hovold wrote: > > > > Drop the obsolete pipe clock handling which was used to treat the pipe > > clock as optional for types other than PCIe and USB and which is no > > longer needed since splitting the PHY driver. > > > > Signed-off-by: Johan Hovold > > --- > > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c > > if (IS_ERR(qphy->pipe_clk)) { > > - if (cfg->type == PHY_TYPE_PCIE || > > - cfg->type == PHY_TYPE_USB3) { > > - ret = PTR_ERR(qphy->pipe_clk); > > - if (ret != -EPROBE_DEFER) > > - dev_err(dev, > > - "failed to get lane%d pipe_clk, %d\n", > > - id, ret); > > - return ret; > > - } > > - qphy->pipe_clk = NULL; > > + return dev_err_probe(dev, PTR_ERR(qphy->pipe_clk), > > + "failed to get lane%d pipe clock\n", id); > > } > > Please remove the brackets around a single statement. For readability reasons I prefer keeping brackets around statements spanning multiple lines instead of relying on indentation. Johan