* [PATCH 1/1] clk/qcom/drivers/sm6350: qcom_cc_really_probe(pdev, &gcc_sm6350_desc, regmap) is assigned an extra semicolon
@ 2022-07-25 2:16 XU pengfei
2022-07-25 7:23 ` Abel Vesa
0 siblings, 1 reply; 4+ messages in thread
From: XU pengfei @ 2022-07-25 2:16 UTC (permalink / raw)
To: agross, bjorn.andersson, konrad.dybcio, mturquette, sboyd
Cc: linux-arm-msm, linux-clk, linux-kernel, Kernel, XU pengfei
I think this semicolon could be deleted.
Signed-off-by: XU pengfei <xupengfei@nfschina.com>
---
drivers/clk/qcom/gcc-sm6350.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/qcom/gcc-sm6350.c b/drivers/clk/qcom/gcc-sm6350.c
index a4f7fba70393..69412400efa4 100644
--- a/drivers/clk/qcom/gcc-sm6350.c
+++ b/drivers/clk/qcom/gcc-sm6350.c
@@ -2558,7 +2558,7 @@ static int gcc_sm6350_probe(struct platform_device *pdev)
if (ret)
return ret;
- return qcom_cc_really_probe(pdev, &gcc_sm6350_desc, regmap);;
+ return qcom_cc_really_probe(pdev, &gcc_sm6350_desc, regmap);
}
static struct platform_driver gcc_sm6350_driver = {
--
2.18.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] clk/qcom/drivers/sm6350: qcom_cc_really_probe(pdev, &gcc_sm6350_desc, regmap) is assigned an extra semicolon
2022-07-25 2:16 [PATCH 1/1] clk/qcom/drivers/sm6350: qcom_cc_really_probe(pdev, &gcc_sm6350_desc, regmap) is assigned an extra semicolon XU pengfei
@ 2022-07-25 7:23 ` Abel Vesa
2022-07-28 9:07 ` [PATCH v2] clk/qcom/gcc-sm6350: Remove unnecessary semicolon XU pengfei
0 siblings, 1 reply; 4+ messages in thread
From: Abel Vesa @ 2022-07-25 7:23 UTC (permalink / raw)
To: XU pengfei
Cc: agross, bjorn.andersson, konrad.dybcio, mturquette, sboyd,
linux-arm-msm, linux-clk, linux-kernel, Kernel
On 22-07-25 10:16:23, XU pengfei wrote:
> I think this semicolon could be deleted.
>
> Signed-off-by: XU pengfei <xupengfei@nfschina.com>
Thank you for your patch, but there are a few things you should change.
First of, the subject line should be something like:
clk: qcom: gcc-sm6350: Remove unnecessary semicolon
Then, your commit message should say what it does.
Maybe something like:
Remove unnecessary semicolon after qcom_cc_really_probe call.
Also, there is a document that describes everthing about submitting
patches. See Documentation/process/submitting-patches.rst.
> ---
> drivers/clk/qcom/gcc-sm6350.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/qcom/gcc-sm6350.c b/drivers/clk/qcom/gcc-sm6350.c
> index a4f7fba70393..69412400efa4 100644
> --- a/drivers/clk/qcom/gcc-sm6350.c
> +++ b/drivers/clk/qcom/gcc-sm6350.c
> @@ -2558,7 +2558,7 @@ static int gcc_sm6350_probe(struct platform_device *pdev)
> if (ret)
> return ret;
>
> - return qcom_cc_really_probe(pdev, &gcc_sm6350_desc, regmap);;
> + return qcom_cc_really_probe(pdev, &gcc_sm6350_desc, regmap);
> }
>
> static struct platform_driver gcc_sm6350_driver = {
> --
> 2.18.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2] clk/qcom/gcc-sm6350: Remove unnecessary semicolon
2022-07-25 7:23 ` Abel Vesa
@ 2022-07-28 9:07 ` XU pengfei
2022-07-28 11:40 ` Abel Vesa
0 siblings, 1 reply; 4+ messages in thread
From: XU pengfei @ 2022-07-28 9:07 UTC (permalink / raw)
To: abel.vesa
Cc: Kernel, agross, bjorn.andersson, konrad.dybcio, linux-arm-msm,
linux-clk, linux-kernel, mturquette, sboyd, xupengfei
Remove unnecessary semicolon after qcom_cc_really_probe call.
Signed-off-by: XU pengfei <xupengfei@nfschina.com>
---
drivers/clk/qcom/gcc-sm6350.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/qcom/gcc-sm6350.c b/drivers/clk/qcom/gcc-sm6350.c
index a4f7fba70393..69412400efa4 100644
--- a/drivers/clk/qcom/gcc-sm6350.c
+++ b/drivers/clk/qcom/gcc-sm6350.c
@@ -2558,7 +2558,7 @@ static int gcc_sm6350_probe(struct platform_device *pdev)
if (ret)
return ret;
- return qcom_cc_really_probe(pdev, &gcc_sm6350_desc, regmap);;
+ return qcom_cc_really_probe(pdev, &gcc_sm6350_desc, regmap);
}
static struct platform_driver gcc_sm6350_driver = {
--
2.18.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] clk/qcom/gcc-sm6350: Remove unnecessary semicolon
2022-07-28 9:07 ` [PATCH v2] clk/qcom/gcc-sm6350: Remove unnecessary semicolon XU pengfei
@ 2022-07-28 11:40 ` Abel Vesa
0 siblings, 0 replies; 4+ messages in thread
From: Abel Vesa @ 2022-07-28 11:40 UTC (permalink / raw)
To: XU pengfei
Cc: Kernel, agross, bjorn.andersson, konrad.dybcio, linux-arm-msm,
linux-clk, linux-kernel, mturquette, sboyd
On 22-07-28 17:07:20, XU pengfei wrote:
> Remove unnecessary semicolon after qcom_cc_really_probe call.
>
> Signed-off-by: XU pengfei <xupengfei@nfschina.com>
> ---
Thanks for this new version, but there are still some issues with it.
First of, don't use slashes in subject. Use semicolons instead.
Have a look at how other commits look like by running:
git log --oneline drivers/clk/qcom/
Also, do not send subsquent versions of a patch as a reply to old ones.
> drivers/clk/qcom/gcc-sm6350.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/qcom/gcc-sm6350.c b/drivers/clk/qcom/gcc-sm6350.c
> index a4f7fba70393..69412400efa4 100644
> --- a/drivers/clk/qcom/gcc-sm6350.c
> +++ b/drivers/clk/qcom/gcc-sm6350.c
> @@ -2558,7 +2558,7 @@ static int gcc_sm6350_probe(struct platform_device *pdev)
> if (ret)
> return ret;
>
> - return qcom_cc_really_probe(pdev, &gcc_sm6350_desc, regmap);;
> + return qcom_cc_really_probe(pdev, &gcc_sm6350_desc, regmap);
> }
>
> static struct platform_driver gcc_sm6350_driver = {
> --
> 2.18.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-28 11:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-25 2:16 [PATCH 1/1] clk/qcom/drivers/sm6350: qcom_cc_really_probe(pdev, &gcc_sm6350_desc, regmap) is assigned an extra semicolon XU pengfei
2022-07-25 7:23 ` Abel Vesa
2022-07-28 9:07 ` [PATCH v2] clk/qcom/gcc-sm6350: Remove unnecessary semicolon XU pengfei
2022-07-28 11:40 ` Abel Vesa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).