From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C09EAC433EF for ; Thu, 21 Jul 2022 10:31:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233236AbiGUKbr (ORCPT ); Thu, 21 Jul 2022 06:31:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233227AbiGUKbq (ORCPT ); Thu, 21 Jul 2022 06:31:46 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69C4B49B68; Thu, 21 Jul 2022 03:31:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1F041B8239C; Thu, 21 Jul 2022 10:31:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A26C5C3411E; Thu, 21 Jul 2022 10:31:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658399502; bh=6cLo27J62FOn04WxOUjgMwROfE1fTOAuDjpYF7NaDwc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=N3WbGRRLy3Wz7OLnE9xyJeuJ98YmI7krfBHCmOr89Wmr2NSJ51Y1NwhDSZL7do3tP lDY5qvEUEDGK3ZBTiKL6N3H0ZCT07piH6XgcsUP+1DBs4MSdglmBv/lSRCP7uEwIHo 4mMndlxHuavBGafCJSi0YU/mpbIMU/S7s9VfQkW5w5ZxcFERww4ElkI91OGgELqIFf G5EdrwfFRy/DS54kxVu04FF7CbSzVwYK0jaycvcvAL/EaMtRLm1k6f/I0Phvlp7+5P ds4flliAvV07XpVp3S/h8s82GLcwQx4i1luvClq9ETl2HPWemt3/RFm/UWrzIwcSD5 4u7MTyS1qBAOQ== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1oETT3-00058P-6k; Thu, 21 Jul 2022 12:31:41 +0200 Date: Thu, 21 Jul 2022 12:31:41 +0200 From: Johan Hovold To: Kuogee Hsieh , Douglas Anderson , Bjorn Andersson , Vinod Koul , Mark Brown Cc: dri-devel@lists.freedesktop.org, robdclark@gmail.com, sean@poorly.run, swboyd@chromium.org, daniel@ffwll.ch, airlied@linux.ie, agross@kernel.org, dmitry.baryshkov@linaro.org, quic_abhinavk@quicinc.com, quic_aravindh@quicinc.com, quic_sbillaka@quicinc.com, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Liam Girdwood , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski Subject: Re: [PATCH v16 0/3] eDP/DP Phy vdda realted function Message-ID: References: <1657038556-2231-1-git-send-email-quic_khsieh@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1657038556-2231-1-git-send-email-quic_khsieh@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, Jul 05, 2022 at 09:29:13AM -0700, Kuogee Hsieh wrote: > 0) rebase on https://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git tree > 1) add regulator_set_load() to eDP phy > 2) add regulator_set_load() to DP phy > 3) remove vdda related function out of eDP/DP controller > > Kuogee Hsieh (3): > phy: qcom-edp: add regulator_set_load to edp phy > phy: qcom-qmp: add regulator_set_load to dp phy > drm/msm/dp: delete vdda regulator related functions from eDP/DP > controller > > drivers/gpu/drm/msm/dp/dp_parser.c | 14 ----- > drivers/gpu/drm/msm/dp/dp_parser.h | 8 --- > drivers/gpu/drm/msm/dp/dp_power.c | 95 +------------------------------ > drivers/phy/qualcomm/phy-qcom-edp.c | 12 ++++ > drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 41 ++++++++++--- > 5 files changed, 46 insertions(+), 124 deletions(-) This series breaks USB and PCIe for some SC8280XP and SA540P machines where the DP PHY regulators are shared with other PHYs whose drivers do not request a load. Specifically, the hard-coded vdda-phy load of 21.8 mA added by this series, causes several RPMh regulators to now be put in low-power mode. I found Doug's suggestion to handle situations like this in regulator core: https://lore.kernel.org/all/20180814170617.100087-1-dianders@chromium.org/ but since that was rejected, how do we deal with this generally? In the above thread Doug mentioned adding support for load requests to further drivers and Bjorn mentioned working around it by adding regulator-system-load properties to DT. It seems quite likely that changes like this one affects other systems too, and the effects may be hard to debug. So a more general solution than playing whack-a-mole using DT would be good to have. Johan